Don't restart cluster on changes that doesn't affect it (issue #379) #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @alexott, TravisBuddy Request Identifier: c110c300-1545-11eb-aff7-dd8cbeb067cc |
Codecov Report
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 70.77% 70.75% -0.03%
==========================================
Files 65 65
Lines 6542 6554 +12
==========================================
+ Hits 4630 4637 +7
- Misses 1477 1482 +5
Partials 435 435
|
nfx
reviewed
Oct 23, 2020
|
it's interesting question - about unit testing of "incremental" change. I've looked through existing testing infrastructure, and couldn't figure out how to do a "single" change to the existing state - right now you need to provide complete state (with Spark version, etc.), but it will trigger the |
|
Hey @alexott, TravisBuddy Request Identifier: bb5c8140-1f3d-11eb-bd2e-17a8c440c3de |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds detection of what cluster parameters were changed, and call
/clusters/editonly we changed parameters that are related to cluster directly, not things like
is_pinnedorlibrary...This fixes #379