Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add databricks_app resource #4099

Merged
merged 116 commits into from
Dec 12, 2024
Merged

[Feature] Add databricks_app resource #4099

merged 116 commits into from
Dec 12, 2024

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Oct 12, 2024 •
edited
Loading

Changes

  • Added databricks_app resource

Resolves #4084

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@nkvuong nkvuong temporarily deployed to test-trigger-is October 29, 2024 09:48 — with GitHub Actions Inactive
@nkvuong nkvuong marked this pull request as ready for review October 29, 2024 09:48
@nkvuong nkvuong requested review from a team as code owners October 29, 2024 09:48
@nkvuong nkvuong requested review from mgyucht and removed request for a team October 29, 2024 09:48
@nkvuong nkvuong temporarily deployed to test-trigger-is October 29, 2024 09:59 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is October 30, 2024 06:25 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is October 30, 2024 08:41 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is October 30, 2024 12:54 — with GitHub Actions Inactive
alexott
alexott requested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes in the doc required, otherwise code looks good

apps/resource_app.go Outdated Show resolved Hide resolved
docs/resources/app.md Outdated Show resolved Hide resolved
docs/resources/app.md Outdated Show resolved Hide resolved
andrewnester
andrewnester reviewed Nov 14, 2024
View reviewed changes
apps/resource_app.go Outdated
return err
}
// now deploy the app, using the source code path
createAppDeployment.AppName = app.Name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we discussed it offline and agreed that the deployment won't be part of TF configuration. Instead, if an users want to deploy, they use CLI to do that. Otherwise it's confusing because we do the deployments only when source_code_path changed but we need to do deployments when source code is changed.

@pietern wdyt?

apps/resource_app.go Outdated
if err != nil {
return err
}
if d.HasChanges("source_code_path", "mode") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment above, I think we should remove app deployment altogether for now

@andrewnester andrewnester requested a review from pietern November 14, 2024 10:46
@github-actions GitHub Actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4099
  • Commit SHA: 52e975cff8b7946a21dad3d175bff155eb26ded1

Checks will be approved automatically on success.

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12297808017

@mgyucht mgyucht enabled auto-merge December 12, 2024 14:08
@mgyucht mgyucht added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 8b63df1 Dec 12, 2024
12 checks passed
@mgyucht mgyucht deleted the feature/app branch December 12, 2024 15:00
mgyucht added a commit that referenced this pull request Dec 12, 2024
@mgyucht
[Release] Release v1.61.0
24e7eab 
### New Features and Improvements

 * Add `databricks_app` resource and data source ([#4099](#4099)).

### Documentation

 * Add a warning that attribute should be used in `databricks_permissions` for `databricks_vector_search_endpoint` ([#4312](#4312)).

### Internal Changes

 * Added TF Plugin Framework checkbox item to PR template and removed checkbox for integration tests passing ([#4227](#4227)).
 * Expose several integration test helpers for use in plugin framework integration tests ([#4310](#4310)).
 * Fix ReadOnly() for ListNestedAttribute and Validators for ListNestedBlock ([#4313](#4313)).
 * Panic if the provided path is invalid ([#4309](#4309)).
 * Simplify `databricks_storage_credential` code ([#4301](#4301)).
 * Use Attributes by default for List Objects ([#4315](#4315)).
 * Use Plugin Framework types internally in generated TF SDK structures ([#4291](#4291)).
@mgyucht mgyucht mentioned this pull request Dec 12, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 12, 2024
@mgyucht
[Release] Release v1.61.0 (#4317)
a7cb6b7 
### New Features and Improvements

* Add `databricks_app` resource and data source
([#4099](#4099)).


### Documentation

* Add a warning that attribute should be used in
`databricks_permissions` for `databricks_vector_search_endpoint`
([#4312](#4312)).


### Internal Changes

* Added TF Plugin Framework checkbox item to PR template and removed
checkbox for integration tests passing
([#4227](#4227)).
* Expose several integration test helpers for use in plugin framework
integration tests
([#4310](#4310)).
* Fix ReadOnly() for ListNestedAttribute and Validators for
ListNestedBlock
([#4313](#4313)).
* Panic if the provided path is invalid
([#4309](#4309)).
* Simplify `databricks_storage_credential` code
([#4301](#4301)).
* Use Attributes by default for List Objects
([#4315](#4315)).
* Use Plugin Framework types internally in generated TF SDK structures
([#4291](#4291)).
alexott
alexott reviewed Dec 12, 2024
View reviewed changes
docs/resources/app.md
resource "databricks_app" "this" {
name = "my-custom-app"
description = "My app"
resources = [{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having resources as array isn't really nice IMHO - individual resource blocks are easier to use

@andrewnester andrewnester mentioned this pull request Dec 13, 2024
Merged
github-merge-queue bot pushed a commit to databricks/cli that referenced this pull request Dec 13, 2024
@andrewnester
Upgrade TF provider to 1.61.0 (#2011)
58dfa70 
## Changes
Upgraded to TF provider 1.61.0

### New Features and Improvements
- Added databricks_app resource and data source
(databricks/terraform-provider-databricks#4099).
- Added databricks_credentials resource and data source
@rauchy rauchy mentioned this pull request Dec 20, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this pull request Dec 20, 2024
@rauchy
[Fix] Reflect backend updates in state for databricks_app (#4337)
4c61683 
## Changes
<!-- Summary of your changes that are easy to understand -->
Following #4099, updates to Databricks Apps only reflected the ones in
the plan, and not the ones coming back from the backend call to update
the app. This PR includes those changes in.

## Tests
<!-- 
How is this tested? Please see the checklist below and also describe any
other relevant tests
-->

- [x] `make test` run locally
- [ ] relevant change in `docs/` folder
- [x] covered with integration tests in `internal/acceptance`
- [x] using Go SDK
- [x] using TF Plugin Framework

Co-authored-by: Omer Lachish <rauchy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

@mgyucht mgyucht mgyucht approved these changes

@rauchy rauchy rauchy approved these changes

@pietern pietern Awaiting requested review from pietern

@andrewnester andrewnester Awaiting requested review from andrewnester

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for Databricks Apps
8 participants
@nkvuong @alexott @andrewnester @nihil0 @eng-dev-ecosystem-bot @pietern @rauchy @mgyucht