[Fix] Mark unity_catalog_provisioning_state as ReadOnly #4116
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauchy
requested review from
mgyucht,
tanmay-db and
hectorcast-db
and removed request for
a team
hectorcast-db
approved these changes
Oct 16, 2024
alexott
requested changes
Oct 16, 2024
catalog/resource_online_table.go
Outdated
| @@ -59,6 +59,7 @@ func ResourceOnlineTable() common.Resource { | |||
| common.CustomizeSchemaPath(m, "spec", "source_table_full_name").SetCustomSuppressDiff(common.EqualFoldDiffSuppress) | |||
| common.CustomizeSchemaPath(m, "name").SetRequired().SetForceNew() | |||
| common.CustomizeSchemaPath(m, "status").SetReadOnly() | |||
| common.CustomizeSchemaPath(m, "unity_catalog_provisioning_state").SetComputed() | |||
There was a problem hiding this comment.
it's better to use .SetReadOnly() because it will set optional and required into correct states
There was a problem hiding this comment.
we also need to add it to the docs?
There was a problem hiding this comment.
Thanks Alex. Could you explain when it makes sense to use computed properties versus readonly properties?
There was a problem hiding this comment.
The SetReadOnly function does a few things:
- set
Computed(doc) - same asSetComputed - It sets
RequiredtofalseandOptionaltotruebecauseComputedcan't be used withRequired. - Sets
MinItemsto 0...
In general, if the field is already Optional, both functions do the same, but SetReadOnly is just safer here because you don't need to check if the field already marked as optional or not.
rauchy
force-pushed
the
rauchy/mark-unity-catalog-provisioning-state-as-computed
branch
from
dbd5a73
to
f11f951
Compare
rauchy
changed the title
alexott
approved these changes
Oct 16, 2024
rauchy
force-pushed
the
rauchy/mark-unity-catalog-provisioning-state-as-computed
branch
from
f11f951
to
25f1b6a
Compare
rauchy
deleted the
rauchy/mark-unity-catalog-provisioning-state-as-computed
branch
hectorcast-db
added a commit
that referenced
this pull request
Oct 17, 2024
### New Features and Improvements * Add `databricks_registered_model` data source ([#4033](#4033)). * Add data source `databricks_notification_destinations` ([#4087](#4087)). ### Bug Fixes * Fix databricks_cluster_pluginframework data source ([#4097](#4097)). * Mark unity_catalog_provisioning_state as ReadOnly ([#4116](#4116)). * Tolerate invalid keys in `databricks_workspace_conf` ([#4102](#4102)). * force send `read_only` in `databricks_external_location` when it's changed ([#4067](#4067)). * force send `read_only` in `databricks_storage_credential` when it's changed ([#4083](#4083)). ### Documentation * Document `budget_policy_id` in `databricks_pipeline` and `databricks_job` ([#4110](#4110)). * Reformat code examples in documentation ([#4081](#4081)). * Update documentation for `databricks_model_serving` ([#4115](#4115)). * Updates to resource examples ([#4093](#4093)). ### Internal Changes * Add maxItem=1 validator for object types in plugin framework schema ([#4094](#4094)). * Fix acceptance test for `databricks_registered_model` data source ([#4105](#4105)). * Generate Effective Fields ([#4057](#4057)). * Generate Effective Fields ([#4112](#4112)). * Set SDK used in the useragent in context ([#4092](#4092)). * Support adding context in resources and data sources ([#4085](#4085)). * Update plugin framework schema to use ListNestedBlocks ([#4040](#4040)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
### New Features and Improvements * Add `databricks_registered_model` data source ([#4033](#4033)). * Add data source `databricks_notification_destinations` ([#4087](#4087)). ### Bug Fixes * Fix databricks_cluster_pluginframework data source ([#4097](#4097)). * Mark unity_catalog_provisioning_state as ReadOnly ([#4116](#4116)). * Tolerate invalid keys in `databricks_workspace_conf` ([#4102](#4102)). * force send `read_only` in `databricks_external_location` when it's changed ([#4067](#4067)). * force send `read_only` in `databricks_storage_credential` when it's changed ([#4083](#4083)). ### Documentation * Document `budget_policy_id` in `databricks_pipeline` and `databricks_job` ([#4110](#4110)). * Reformat code examples in documentation ([#4081](#4081)). * Update documentation for `databricks_model_serving` ([#4115](#4115)). * Updates to resource examples ([#4093](#4093)). ### Internal Changes * Add maxItem=1 validator for object types in plugin framework schema ([#4094](#4094)). * Fix acceptance test for `databricks_registered_model` data source ([#4105](#4105)). * Generate Effective Fields ([#4057](#4057)). * Generate Effective Fields ([#4112](#4112)). * Set SDK used in the useragent in context ([#4092](#4092)). * Support adding context in resources and data sources ([#4085](#4085)). * Update plugin framework schema to use ListNestedBlocks ([#4040](#4040)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In a recent update to the GoSDK, a new field called
unity_catalog_provisioning_statewas added. This field changes values based on server decisions, so it's supposed to be marked as computed. This pull request sorts out that issue.Tests
make testrun locallydocs/folderinternal/acceptance