-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter] Allow to match resource names by regular expression #4177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to existing `-match` option, this PR allows to match names by regex during the listing operation. There are two options: - `-matchRegex` - checks if name matches a regex - this could be useful for exporting notebooks for only specific users, or something like that. - `-excludeRegex` - checks if name matches a regex, and skips processing of that object. For example, it could be used to exclude `databricks_automl` directories. This parameter has higher priority than the `-match` and `-matchRegex`.
alexott
temporarily deployed
to
test-trigger-is
October 31, 2024 08:54 — with
GitHub Actions
Inactive
mgyucht
approved these changes
Oct 31, 2024
alexott
temporarily deployed
to
test-trigger-is
October 31, 2024 13:02 — with
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
October 31, 2024 13:12 — with
GitHub Actions
Inactive
mgyucht
approved these changes
Oct 31, 2024
Co-authored-by: Miles Yucht <miles@databricks.com>
alexott
temporarily deployed
to
test-trigger-is
October 31, 2024 13:40 — with
GitHub Actions
Inactive
Test Details: go/deco-tests/11613030493 |
tanmay-db
added a commit
that referenced
this pull request
Nov 5, 2024
### New Features and Improvements * Added `databricks_functions` data source ([#4154](#4154)). ### Bug Fixes * Handle edge case for `effective_properties` in `databricks_sql_table` ([#4153](#4153)). * Provide more prescriptive error when users fail to create a single node cluster ([#4168](#4168)). ### Internal Changes * Add test instructions for external contributors ([#4169](#4169)). * Always write message for manual test integration ([#4188](#4188)). * Make `Read` after `Create`/`Update` configurable ([#4190](#4190)). * Migrate Share Data Source to Plugin Framework ([#4161](#4161)). * Migrate Share Resource to Plugin Framework ([#4047](#4047)). * Rollout Plugin Framework ([#4134](#4134)). ### Dependency Updates * Bump Go SDK to v0.50.0 ([#4178](#4178)). ### Exporter * Allow to match resource names by regular expression ([#4177](#4177)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
### New Features and Improvements * Added `databricks_functions` data source ([#4154](#4154)). ### Bug Fixes * Handle edge case for `effective_properties` in `databricks_sql_table` ([#4153](#4153)). * Provide more prescriptive error when users fail to create a single node cluster ([#4168](#4168)). ### Internal Changes * Add test instructions for external contributors ([#4169](#4169)). * Always write message for manual test integration ([#4188](#4188)). * Make `Read` after `Create`/`Update` configurable ([#4190](#4190)). * Migrate Share Data Source to Plugin Framework ([#4161](#4161)). * Migrate Share Resource to Plugin Framework ([#4047](#4047)). * Rollout Plugin Framework ([#4134](#4134)). ### Dependency Updates * Bump Go SDK to v0.50.0 ([#4178](#4178)). ### Exporter * Allow to match resource names by regular expression ([#4177](#4177)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In addition to the existing
-match
option, this PR allows the matching of names by regex during the listing operation. There are new options:-matchRegex
- checks if name matches a regex - this could be useful for exporting notebooks for only specific users, or something like that.-excludeRegex
- checks if name matches a regex, and skips processing of that object. For example, it could be used to excludedatabricks_automl
directories. This parameter has higher priority than the-match
and-matchRegex
.filterDirectoriesDuringWorkspaceWalking
- if we should apply match logic to directory names when we're performing workspace tree walking. Note: be careful with it as it will be applied to all entries, so if you want to filter only specific users, then you will need to specify the condition for/Users
as well, so regex will be^(/Users|/Users/[a-c].*)$
Tests
make test
run locallydocs/
folderinternal/acceptance