[Internal] Bump Go SDK and generate TF structs #4300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
commented
Dec 6, 2024
| // the format of *catalog*.*schema*.*table_name* | ||
| LocalName types.String `tfsdk:"local_name" tf:"optional"` | ||
| // Partition filtering specification for a shared table. | ||
| Partitions sharing.PartitionSpecificationPartition `tfsdk:"partitions" tf:"optional"` |
There was a problem hiding this comment.
This should use sharing_tf instead of sharing.
There was a problem hiding this comment.
This most likely is a bug in generation, we would need to fix this before we can merge.
There was a problem hiding this comment.
@tanmay-db is it really a blocker? We don't have any CleanRoom-related resource yet...
Imho it could be fixed in the subsequent SDK updates
There was a problem hiding this comment.
Hi @alexott, it's not a blocker, we discussed this yesterday in our meeting and since it's an existing bug we are going ahead with the release.
alexott
approved these changes
Dec 6, 2024
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Test Details: go/deco-tests/12239435538 |
|
Regenerated on latest genkit and had no diff, going ahead with merge |
tanmay-db
added a commit
that referenced
this pull request
Dec 10, 2024
### New Features and Improvements * Add `databricks_credential` resource ([#4219](#4219)). * Allow to filter jobs by name in `databricks_jobs` data source ([#3395](#3395)). ### Bug Fixes * Add client side validation for `volume_type` ([#4289](#4289)). * Add missing H2 header in `mws_network_connectivity_configs.md` and optimization in `data_mws_network_connectivity_configs` ([#4256](#4256)). * Forced send `auto_stop_mins` for `databricks_sql_endpoint` resource ([#4265](#4265)). * Handle deleted cluster gracefully ([#4280](#4280)). * Remove config drift if Azure SP is used in `databricks_credential` ([#4294](#4294)). * Use correct domain for Azure Gov and China ([#4274](#4274)). * don't start cluster if `warehouse_id` is specified for `databricks_sql_table` resource ([#4259](#4259)). ### Documentation * Document import support for `databricks_notification_destination` ([#4276](#4276)). * Update documentation for importing some MWS resources ([#4281](#4281)). * Update mws_log_delivery.md to add time_sleep ([#4258](#4258)). ### Internal Changes * Add ConvertToAttribute() to convert blocks in a resource/data source schema to attributes ([#4284](#4284)). * Bump Go SDK and generate TF structs ([#4300](#4300)). * Generate effective fields based of isServiceProposedIfEmpty ([#4282](#4282)). * Ignore Databricks Go SDK updates by dependabot ([#4253](#4253)). * Move TFSDK model template to universe ([#4303](#4303)). * Remove unused configuration from blocks ([#4283](#4283)). * Use isServiceProposedIfEmpty annotations for effective fields ([#4270](#4270)). * Use tf_v1 genkit mode ([#4278](#4278)). ### Dependency Updates * Bump github.com/stretchr/testify from 1.9.0 to 1.10.0 ([#4269](#4269)). * Bump github.com/zclconf/go-cty from 1.15.0 to 1.15.1 ([#4273](#4273)). ### Exporter * Fix generation of references to users for user directories ([#4297](#4297)). * better handling of online tables/vsis in listing ([#4288](#4288)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
### New Features and Improvements * Add `databricks_credential` resource ([#4219](#4219)). * Allow to filter jobs by name in `databricks_jobs` data source ([#3395](#3395)). ### Bug Fixes * Add client side validation for `volume_type` ([#4289](#4289)). * Add missing H2 header in `mws_network_connectivity_configs.md` and optimization in `data_mws_network_connectivity_configs` ([#4256](#4256)). * Forced send `auto_stop_mins` for `databricks_sql_endpoint` resource ([#4265](#4265)). * Handle deleted cluster gracefully ([#4280](#4280)). * Remove config drift if Azure SP is used in `databricks_credential` ([#4294](#4294)). * Use correct domain for Azure Gov and China ([#4274](#4274)). * don't start cluster if `warehouse_id` is specified for `databricks_sql_table` resource ([#4259](#4259)). ### Documentation * Document import support for `databricks_notification_destination` ([#4276](#4276)). * Update documentation for importing some MWS resources ([#4281](#4281)). * Update mws_log_delivery.md to add time_sleep ([#4258](#4258)). ### Internal Changes * Add ConvertToAttribute() to convert blocks in a resource/data source schema to attributes ([#4284](#4284)). * Bump Go SDK and generate TF structs ([#4300](#4300)). * Generate effective fields based of isServiceProposedIfEmpty ([#4282](#4282)). * Ignore Databricks Go SDK updates by dependabot ([#4253](#4253)). * Move TFSDK model template to universe ([#4303](#4303)). * Remove unused configuration from blocks ([#4283](#4283)). * Use isServiceProposedIfEmpty annotations for effective fields ([#4270](#4270)). * Use tf_v1 genkit mode ([#4278](#4278)). ### Dependency Updates * Bump github.com/stretchr/testify from 1.9.0 to 1.10.0 ([#4269](#4269)). * Bump github.com/zclconf/go-cty from 1.15.0 to 1.15.1 ([#4273](#4273)). ### Exporter * Fix generation of references to users for user directories ([#4297](#4297)). * better handling of online tables/vsis in listing ([#4288](#4288)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Bump Go SDK to latest and generate TF structs to same OpenAPI spec as Go SDK
Tests
N/A
make testrun locallydocs/folderinternal/acceptance