Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] handle auto-enabled errors withdatabricks_system_schema #4547

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Mar 4, 2025

Changes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@nkvuong nkvuong requested review from a team as code owners March 4, 2025 08:34
@nkvuong nkvuong requested review from hectorcast-db and removed request for a team March 4, 2025 08:34
@nkvuong nkvuong temporarily deployed to test-trigger-is March 4, 2025 08:34 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 4, 2025 08:35 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 4, 2025 13:24 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 4, 2025 13:24 — with GitHub Actions Inactive
@alexott
Copy link
Contributor

alexott commented Mar 4, 2025

@nkvuong how it will handle destroy? Will it fail trying to disable the schema?

@nkvuong nkvuong force-pushed the fix/system_tables branch from 16d8fc2 to 1f067fc Compare March 5, 2025 07:10
@nkvuong nkvuong temporarily deployed to test-trigger-is March 5, 2025 07:10 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 5, 2025 07:12 — with GitHub Actions Inactive
@nkvuong
Copy link
Contributor Author

nkvuong commented Mar 5, 2025

@nkvuong how it will handle destroy? Will it fail trying to disable the schema?

@alexott our API actually succeeds 😕

@nkvuong nkvuong temporarily deployed to test-trigger-is March 5, 2025 07:21 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 5, 2025 07:22 — with GitHub Actions Inactive
@alexott
Copy link
Contributor

alexott commented Mar 5, 2025

@nkvuong maybe we can add a computed flag that specifies that it's auto-enabled? And then in the Delete skip the deletion?

@nkvuong nkvuong temporarily deployed to test-trigger-is March 5, 2025 12:49 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 5, 2025 12:50 — with GitHub Actions Inactive
@nkvuong nkvuong requested a review from alexott March 5, 2025 12:51
@nkvuong nkvuong temporarily deployed to test-trigger-is March 5, 2025 12:55 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 5, 2025 12:56 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is March 11, 2025 19:07 — with GitHub Actions Inactive
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4547
  • Commit SHA: d127b8c8183eb483a892627d006355706e9e66be

Checks will be approved automatically on success.

@alexott alexott temporarily deployed to test-trigger-is March 11, 2025 19:09 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Failures for Auto-Enabled System Tables
2 participants