Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 0.3.0 release #464

Merged
merged 32 commits into from
Jan 29, 2021
Merged

Prepare 0.3.0 release #464

merged 32 commits into from
Jan 29, 2021

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Jan 22, 2021 •
edited
Loading

azcli

  • TestAccClusterResource_CreateClusterWithLibraries (307.67s)
  • TestAccSecretScopeResource (21.15s)
  • access.TestAccPermissionsClusterPolicy (22.97s)
  • access.TestAccPermissionsClusters (315.19s)
  • access.TestAccPermissionsInstancePool (17.70s)
  • access.TestAccPermissionsJobs (18.53s)
  • access.TestAccPermissionsNotebooks (19.33s)
  • access.TestAccPermissionsTokens (15.65s)
  • access/acceptance.TestAccDatabricksPermissionsResourceFullLifecycle (56.90s)
  • access/acceptance.TestAccInitialManagePrincipals (2.76s)
  • access/acceptance.TestAccInitialManagePrincipalsGroup (1.72s)
  • access/acceptance.TestAccSecretAclResource (19.21s)
  • access/acceptance.TestAccSecretAclResourceDefaultPrincipal (14.45s)
  • access/acceptance.TestAccSecretResource (21.20s)
  • access/acceptance.TestAzureAccKeyVaultSimple (3.10s)
  • compute.TestAccContext (54.13s)
  • compute.TestAccInstancePools (6.87s)
  • compute.TestAccLibraryCreate (90.33s)
  • compute.TestAccListClustersIntegration (262.03s)
  • compute.TestAzureAccNodeTypes (3.06s)
  • compute/acceptance.TestAccClusterPolicyResourceFullLifecycle (31.58s)
  • compute/acceptance.TestAccClusterResource_CreateSingleNodeCluster (263.09s)
  • compute/acceptance.TestAccJobResource (21.82s)
  • identity.TestAccCreateToken (3.84s)
  • identity.TestAccCreateUser (9.39s)
  • identity.TestAccFilterGroup (4.13s)
  • identity.TestAccGroup (28.59s)
  • identity.TestAccReadUser (4.45s)
  • identity.TestAzureAccSP (10.97s)
  • identity/acceptance.TestAccGroupMemberResource (29.86s)
  • identity/acceptance.TestAccGroupResource (33.05s)
  • identity/acceptance.TestAccGroupResource_verify_entitlements (23.59s)
  • identity/acceptance.TestAccTokenResource (13.84s)
  • identity/acceptance.TestAccUserResource (25.41s)
  • identity/acceptance.TestAzureAccServicePrincipalResource (28.68s)
  • internal/sanity.TestAccMissingResourcesInWorkspace (4.79s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Cluster_Policies (0.49s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Cluster_Policies_Delete (0.48s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Clusters (0.31s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/DBFS_Files (0.67s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Groups (0.80s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Instance_Pools (0.22s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Jobs (0.22s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Notebooks (0.20s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secret_ACLs (0.20s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secret_Scopes (0.15s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secrets (0.15s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Tokens (0.53s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Users (0.37s)
  • internal/sanity.TestAccMutiworkspaceUsedFromNormalMode (9.00s)
  • storage.TestAccCreateFile (5.75s)
  • storage.TestAccDeleteInvalidMountFails (7.44s)
  • storage.TestAccInvalidSecretScopeFails (7.35s)
  • storage.TestAccSourceOnInvalidMountFails (30.34s)
  • storage.TestAzureAccBlobMount (150.22s)
  • storage/acceptance.TestAccDatabricksDBFSFile_CreateViaContent (21.70s)
  • storage/acceptance.TestAccDatabricksDBFSFile_CreateViaSource (10.38s)
  • storage/acceptance.TestAzureAccBlobMount_correctly_mounts (675.16s)
  • workspace/acceptance.TestAccNotebookResourceScalability (24.51s)
  • workspace/acceptance.TestAccWorkspaceConfFullLifecycle (11.01s)

awsmt

  • TestAccClusterResource_CreateClusterWithLibraries (222.10s)
  • TestAccClusterResource_CreateSingleNodeCluster (196.51s)
  • TestAwsAccGroupInstanceProfileResource (1138.57s)
  • TestAwsAccS3IamMount_WithCluster (1143.30s)
  • access.TestAccIPACL (3.31s)
  • access.TestAccPermissionsClusterPolicy (12.93s)
  • access.TestAccPermissionsClusters (215.48s)
  • access.TestAccPermissionsInstancePool (15.51s)
  • access.TestAccPermissionsJobs (16.82s)
  • access.TestAccPermissionsNotebooks (16.73s)
  • access.TestAccPermissionsTokens (15.20s)
  • access/acceptance.TestAccDatabricksPermissionsResourceFullLifecycle (31.54s)
  • access/acceptance.TestAccInitialManagePrincipals (1.81s)
  • access/acceptance.TestAccInitialManagePrincipalsGroup (0.77s)
  • access/acceptance.TestAccSecretAclResource (13.52s)
  • access/acceptance.TestAccSecretAclResourceDefaultPrincipal (5.29s)
  • access/acceptance.TestAccSecretResource (5.00s)
  • access/acceptance.TestAccSecretScopeResource (6.29s)
  • compute.TestAccContext (110.52s)
  • compute.TestAccInstancePools (2.82s)
  • compute.TestAccLibraryCreate (73.10s)
  • compute.TestAccListClustersIntegration (197.05s)
  • compute.TestAwsAccSmallestNodeType (0.21s)
  • compute/acceptance.TestAccClusterPolicyResourceFullLifecycle (6.93s)
  • compute/acceptance.TestAccJobResource (2.76s)
  • compute/acceptance.TestAwsAccJobResource_NoInstancePool (2.32s)
  • compute/acceptance.TestAwsAccJobsCreate (1.93s)
  • identity.TestAccCreateToken (0.71s)
  • identity.TestAccCreateUser (9.44s)
  • identity.TestAccFilterGroup (1.87s)
  • identity.TestAccGroup (21.56s)
  • identity.TestAccReadUser (1.73s)
  • identity.TestAwsAccInstanceProfiles (1122.07s)
  • identity/acceptance.TestAccGroupResource (13.95s)
  • identity/acceptance.TestAccGroupResource_verify_entitlements (12.52s)
  • internal/sanity.TestAccMissingResourcesInWorkspace (4.01s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Cluster_Policies (0.44s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Cluster_Policies_Delete (0.43s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Clusters (0.27s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/DBFS_Files (1.20s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Groups (0.13s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Instance_Pools (0.13s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Instance_Profiles (0.12s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Jobs (0.15s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Notebooks (0.15s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secret_ACLs (0.16s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secret_Scopes (0.05s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secrets (0.07s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Tokens (0.55s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Users (0.15s)
  • internal/sanity.TestAccMutiworkspaceUsedFromNormalMode (1.38s)
  • storage.TestAccCreateFile (2.66s)
  • storage.TestAccDeleteInvalidMountFails (4.28s)
  • storage.TestAccInvalidSecretScopeFails (3.23s)
  • storage.TestAccSourceOnInvalidMountFails (32.18s)
  • storage.TestAwsAccS3Mount (335.19s)
  • workspace/acceptance.TestAccNotebookResourceScalability (5.04s)
  • workspace/acceptance.TestAccWorkspaceConfFullLifecycle (2.61s)

mws

  • TestMwsAccWorkspaces (113.80s)
  • mws.TestMwsAccCreds (3.52s)
  • mws.TestMwsAccCustomerManagedKeys (3.47s)
  • mws.TestMwsAccLogDelivery (8.28s)
  • mws.TestMwsAccMissingResources (4.19s)
  • mws.TestMwsAccMissingResources/Credential (1.01s)
  • mws.TestMwsAccMissingResources/Customer_Managed_Key (0.79s)
  • mws.TestMwsAccMissingResources/Network (0.74s)
  • mws.TestMwsAccMissingResources/Storage (0.77s)
  • mws.TestMwsAccMissingResources/Workspace (0.88s)
  • mws.TestMwsAccPAS (2.36s)
  • mws.TestMwsAccStorageConfigurations (3.15s)
  • mws.TestMwsAccVPCEndpoint (106.47s)
  • mws.TestMwsAccWorkspace (0.78s)
  • mws/acceptance.TestMwsAccCredentials (6.28s)
  • mws/acceptance.TestMwsAccCustomerManagedKeys (7.43s)
  • mws/acceptance.TestMwsAccLogDelivery (12.69s)
  • mws/acceptance.TestMwsAccNetworks (5.97s)
  • mws/acceptance.TestMwsAccPrivateAccessSettings (5.38s)
  • mws/acceptance.TestMwsAccStorageConfigurations (6.41s)

azsp

  • TestAzureAccADLSv1Mount (4.84s)
  • access.TestAccIPACL (12.16s)
  • access.TestAccPermissionsClusterPolicy (15.29s)
  • access.TestAccPermissionsClusters (275.30s)
  • access.TestAccPermissionsInstancePool (16.62s)
  • access.TestAccPermissionsJobs (13.75s)
  • access.TestAccPermissionsNotebooks (15.63s)
  • access.TestAccPermissionsTokens (12.65s)
  • access/acceptance.TestAccDatabricksPermissionsResourceFullLifecycle (48.42s)
  • access/acceptance.TestAccInitialManagePrincipals (1.78s)
  • access/acceptance.TestAccInitialManagePrincipalsGroup (0.86s)
  • access/acceptance.TestAccSecretAclResource (16.82s)
  • access/acceptance.TestAccSecretAclResourceDefaultPrincipal (9.64s)
  • access/acceptance.TestAccSecretResource (15.42s)
  • access/acceptance.TestAccSecretScopeResource (12.23s)
  • compute.TestAccContext (96.49s)
  • compute.TestAccInstancePools (4.15s)
  • compute.TestAccLibraryCreate (66.92s)
  • compute.TestAccListClustersIntegration (261.96s)
  • compute.TestAzureAccNodeTypes (0.72s)
  • compute/acceptance.TestAccClusterPolicyResourceFullLifecycle (26.00s)
  • compute/acceptance.TestAccJobResource (8.92s)
  • identity.TestAccCreateToken (2.97s)
  • identity.TestAccCreateUser (8.79s)
  • identity.TestAccFilterGroup (2.35s)
  • identity.TestAccGroup (28.77s)
  • identity.TestAccReadUser (2.00s)
  • identity.TestAzureAccSP (8.29s)
  • identity/acceptance.TestAccGroupMemberResource (29.76s)
  • identity/acceptance.TestAccGroupResource (25.51s)
  • identity/acceptance.TestAccGroupResource_verify_entitlements (16.03s)
  • identity/acceptance.TestAccTokenResource (10.76s)
  • identity/acceptance.TestAccUserResource (18.16s)
  • identity/acceptance.TestAzureAccServicePrincipalResource (18.79s)
  • internal/sanity.TestAccMissingResourcesInWorkspace (6.25s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Cluster_Policies (0.96s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Cluster_Policies_Delete (0.36s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Clusters (0.45s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/DBFS_Files (1.21s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Groups (0.84s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Instance_Pools (0.32s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Jobs (0.33s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Notebooks (0.22s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secret_ACLs (0.31s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secret_Scopes (0.26s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secrets (0.26s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Tokens (0.60s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Users (0.11s)
  • internal/sanity.TestAccMutiworkspaceUsedFromNormalMode (10.86s)
  • storage/acceptance.TestAzureAccAdlsGen1Mount_correctly_mounts (432.83s)
  • workspace/acceptance.TestAccNotebookResourceScalability (18.98s)
  • workspace/acceptance.TestAccWorkspaceConfFullLifecycle (7.89s)

@nfx nfx requested a review from alexott January 22, 2021 20:21
@nfx nfx self-assigned this Jan 22, 2021
@nfx nfx added this to the v0.3.0 milestone Jan 22, 2021
alexott
alexott requested changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be useful to highlight some breaking changes

docs/guides/migration-0.3.x.md Outdated Show resolved Hide resolved
docs/guides/migration-0.3.x.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
docs/resources/cluster.md Show resolved Hide resolved
@alexott
Copy link
Contributor

alexott commented Jan 23, 2021

Lint is also failed

@codecov
Copy link

codecov bot commented Jan 24, 2021 •
edited
Loading

Codecov Report

Merging #464 (6976531) into master (d7e3bd9) will increase coverage by 0.96%.
The diff coverage is 70.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
+ Coverage   81.24%   82.21%   +0.96%     
==========================================
  Files          68       69       +1     
  Lines        5263     5330      +67     
==========================================
+ Hits         4276     4382     +106     
+ Misses        664      631      -33     
+ Partials      323      317       -6
Impacted Files Coverage Δ
common/version.go 20.00% <ø> (ø)
identity/resource_service_principal.go 94.52% <ø> (+3.73%) ⬆️
identity/scim.go 100.00% <ø> (ø)
internal/util/common_resource.go 64.00% <ø> (ø)
storage/aws_s3_mount.go 65.55% <0.00%> (-2.27%) ⬇️
identity/resource_instance_profile.go 65.34% <7.14%> (-13.23%) ⬇️
workspace/file_resource.go 45.00% <30.00%> (-9.44%) ⬇️
internal/qa/testing.go 80.64% <33.33%> (-0.33%) ⬇️
mws/resource_workspace.go 80.30% <71.42%> (ø)
provider/provider.go 93.43% <78.04%> (+0.07%) ⬆️
... and 19 more

@alexott alexott self-requested a review January 24, 2021 16:42
alexott
alexott approved these changes Jan 24, 2021
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx changed the title Prepare 0.3.0 releasd Prepare 0.3.0 release Jan 25, 2021
@nfx nfx linked an issue Jan 29, 2021 that may be closed by this pull request
[ISSUE] Unable to destroy IP Access Lists #426
Closed
@nfx nfx merged commit cdef6f9 into master Jan 29, 2021
@nfx nfx deleted the prepare/0.3.0 branch January 29, 2021 18:15
@muralijv
Copy link

muralijv commented Feb 4, 2021

Hello Guys
How do I define a cluster mode or type ( standard or High concurrency) in Azure Databricks Terraform resource. May I know the property name . Thanks for your help

@mgyucht mgyucht mentioned this pull request Dec 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

Assignees

@nfx nfx

Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

[ISSUE] Unable to destroy IP Access Lists
4 participants
@nfx @alexott @muralijv @stikkireddy