Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent setting any permissions to admins group #487

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Prevent setting any permissions to admins group #487

merged 1 commit into from
Feb 9, 2021

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Feb 8, 2021

Fixes #486

@nfx nfx requested a review from alexott February 8, 2021 20:09
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #487 (74f7ee5) into master (adc04b3) will increase coverage by 0.02%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
+ Coverage   77.27%   77.30%   +0.02%     
==========================================
  Files          74       74              
  Lines        6161     6172      +11     
==========================================
+ Hits         4761     4771      +10     
- Misses       1050     1051       +1     
  Partials      350      350              
Impacted Files Coverage Δ
access/resource_permissions.go 70.76% <90.90%> (+1.38%) ⬆️

Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx
Copy link
Contributor Author

nfx commented Feb 8, 2021

alternatively it could be a state func to ignore access control change if there's group_name="admins"

@nfx nfx merged commit 76f1ef2 into master Feb 9, 2021
@nfx nfx deleted the issue/486 branch February 9, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants