[RESOURCE] databricks_sql_endpoint #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
==========================================
- Coverage 80.80% 80.37% -0.44%
==========================================
Files 76 77 +1
Lines 6382 6502 +120
==========================================
+ Hits 5157 5226 +69
- Misses 847 891 +44
- Partials 378 385 +7
|
alexott
reviewed
Feb 10, 2021
|
@georgeteo this is the PR |
alexott
reviewed
Feb 11, 2021
Addresses #457
nfx
changed the title
alexott
requested changes
Feb 11, 2021
georgeteo
reviewed
Feb 15, 2021
| } | ||
|
|
||
| // Create ... | ||
| func (a SQLEndpointsAPI) Create(se *SQLEndpoint, timeout time.Duration) error { |
There was a problem hiding this comment.
Technically, CreateEndpoint and EditEndpoint are different proto messages from the EndpointInfo returned by GetEndpoint or ListEndpoints.
So far, the fields have mirrored them 1:1 but is not necessarily true in the future.
| if err != nil { | ||
| return err | ||
| } | ||
| return a.waitForRunning(se.ID, timeout) |
There was a problem hiding this comment.
FYI: This may take a couple minutes b/c we wait for the Spark cluster to be running.
|
|
||
| // Edit ... | ||
| func (a SQLEndpointsAPI) Edit(se SQLEndpoint) error { | ||
| return a.client.Post(a.context, fmt.Sprintf("/sql/endpoints/%s/edit", se.ID), se, nil) |
There was a problem hiding this comment.
FYI: Edit supports patch/incremental update. It's fine if you treat it as a post.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #457