Support for spot instances on Azure #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexott
force-pushed
the
azure-spot-instances
branch
from
f0eb591
to
5adb2dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
==========================================
+ Coverage 81.61% 81.65% +0.04%
==========================================
Files 77 77
Lines 6663 6678 +15
==========================================
+ Hits 5438 5453 +15
Misses 815 815
Partials 410 410
|
alexott
force-pushed
the
azure-spot-instances
branch
from
5adb2dd
to
81fa607
Compare
nfx
approved these changes
Mar 23, 2021
| @@ -321,6 +324,12 @@ func modifyClusterRequest(clusterModel *Cluster) { | |||
| } | |||
| clusterModel.AwsAttributes = &awsAttributes | |||
| } | |||
| if clusterModel.AzureAttributes != nil { | |||
| clusterModel.AzureAttributes = nil | |||
There was a problem hiding this comment.
nit: can we add a unit test here
There was a problem hiding this comment.
But does it make sense to nil the field if it's not nil?..
There was a problem hiding this comment.
all Azure attributes now are related to the Spot instances only, and if we're using instance pools, then we shouldn't override instance types?
compute/resource_cluster.go
Outdated
| clusterModel.AzureAttributes = nil | ||
| } | ||
| if clusterModel.GcpAttributes != nil { | ||
| clusterModel.GcpAttributes = nil |
There was a problem hiding this comment.
nit: can we add a unit test here
| @@ -61,6 +61,8 @@ func ResourceInstancePool() *schema.Resource { | |||
| s["custom_tags"].ForceNew = true | |||
| s["enable_elastic_disk"].ForceNew = true | |||
| s["enable_elastic_disk"].Default = true | |||
| s["aws_attributes"].ConflictsWith = []string{"azure_attributes"} | |||
| s["azure_attributes"].ConflictsWith = []string{"aws_attributes"} | |||
There was a problem hiding this comment.
no gcp attributes for instance pools?
There was a problem hiding this comment.
there is no instance pools support yet, so I can't test it - will add later
nfx
approved these changes
Mar 24, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Azure spot instances for clusters & instance pools. It also adds an additional support for preemptible executors on GCP (only for clsuters)