add data source user #648
Merged
add data source user #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
requested changes
May 13, 2021
identity/data_user.go
Outdated
| func DataSourceUser() *schema.Resource { | ||
| type entity struct { | ||
| UserName string `json:"user_name"` | ||
| Home string `json:"home" tf:"computed"` |
identity/data_user.go
Outdated
| Alphanumeric string `json:"alphanumeric" tf:"computed"` | ||
| } | ||
|
|
||
| s := common.StructToSchema(entity{}, func( |
There was a problem hiding this comment.
By the way, if you feel that schema map is shorter - you can do it as well :) just a side thought
identity/data_user.go
Outdated
| s := common.StructToSchema(entity{}, func( | ||
| s map[string]*schema.Schema) map[string]*schema.Schema { | ||
| // nolint once SDKv2 has Diagnostics-returning validators, change | ||
| s["user_name"].ValidateFunc = validation.StringIsNotEmpty |
There was a problem hiding this comment.
We've migrated to other linter, so comment above might not work. You need ValidateDiagFunc and wrap this sdkv1 one
There was a problem hiding this comment.
I guess it's done now that I've changed to schema map.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #647