Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional external_id field to SCIM users and groups #927

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Nov 18, 2021

External ID could be propagated from linked identity provider, and is used for things like Unity Catalog

External ID could be propagated from linked identity provider, and is used for things like
Unity Catalog
@alexott alexott requested a review from nfx November 18, 2021 12:07
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #927 (6ef27b3) into master (57d334d) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
+ Coverage   83.56%   83.62%   +0.05%     
==========================================
  Files          93       93              
  Lines        8648     8677      +29     
==========================================
+ Hits         7227     7256      +29     
  Misses        910      910              
  Partials      511      511              
Impacted Files Coverage Δ
identity/scim.go 92.59% <ø> (ø)
identity/data_current_user.go 94.73% <100.00%> (+0.79%) ⬆️
identity/data_group.go 82.60% <100.00%> (+0.79%) ⬆️
identity/data_user.go 96.61% <100.00%> (+0.69%) ⬆️
identity/groups.go 88.09% <100.00%> (+0.29%) ⬆️
identity/resource_group.go 100.00% <100.00%> (ø)
identity/resource_user.go 87.75% <100.00%> (+0.79%) ⬆️

Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add an entry to changelog

@nfx nfx merged commit d891e49 into master Nov 18, 2021
@nfx nfx deleted the scim-external-id-support branch November 18, 2021 12:15
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
External ID could be propagated from linked identity provider, and is used for things like
Unity Catalog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants