Ignore autoaz changes #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #937 +/- ##
=======================================
Coverage 85.32% 85.32%
=======================================
Files 95 95
Lines 8663 8670 +7
=======================================
+ Hits 7392 7398 +6
- Misses 778 779 +1
Partials 493 493
|
nfx
requested changes
Nov 30, 2021
clusters/resource_cluster.go
Outdated
| @@ -47,9 +48,19 @@ func SparkConfDiffSuppressFunc(k, old, new string, d *schema.ResourceData) bool | |||
| return false | |||
| } | |||
|
|
|||
| func AwsAttribsDiffSuppressFunc(k, old, new string, d *schema.ResourceData) bool { | |||
| if strings.HasPrefix(k, "aws_attributes.") && | |||
There was a problem hiding this comment.
Just check for key as a string - I've made GoLang custom struct fields to translate as always-single-element-lists, so you can be sure of first element being zero
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will prevent Terraform to restart a cluster which AwsAttributes.zone_id = "auto", as this is an unneeded/unwanted behavior.