top metrics #79
Merged
top metrics #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchen-db
requested review from
a team,
christopherzli,
jnyi,
hczhu-db and
yulong-db
and removed request for
a team
jnyi
reviewed
Sep 16, 2024
| return runutil.Repeat(conf.topMetricsUpdateInterval, ctx.Done(), func() error { | ||
| level.Error(logger).Log("msg", "getting top metrics") | ||
| for _, ts := range dbs.TenantStats(conf.numTopMetricsPerTenant, labels.MetricName) { | ||
| for _, ms := range ts.Stats.IndexPostingStats.CardinalityMetricsStats { |
There was a problem hiding this comment.
is the return value not a reference so no read lock are needed? maybe use go -race to check
jnyi
reviewed
Sep 16, 2024
| level.Error(logger).Log("msg", "getting top metrics") | ||
| for _, ts := range dbs.TenantStats(conf.numTopMetricsPerTenant, labels.MetricName) { | ||
| for _, ms := range ts.Stats.IndexPostingStats.CardinalityMetricsStats { | ||
| if ms.Count >= conf.topMetricsMinimumCardinality { |
There was a problem hiding this comment.
👍 we can avoid emitting small metrics
jnyi
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/databricks/universe/pull/719982