Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature streaming 040824 #272

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

ronanstokes-db
Copy link
Contributor

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers.
If it fixes a bug or resolves a feature request, please provide a link to that issue.

Types of changes

What types of changes does your code introduce to dbldatagen?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to tutorials, tests or examples
  • Non code change (readme, images or other non-code assets)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Submission does not reduce code coverage numbers
  • Submission does not increase alerts or messages from prospector / lint

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@ronanstokes-db ronanstokes-db requested a review from a team as a code owner May 16, 2024 23:49
@ronanstokes-db ronanstokes-db requested review from howardwu-db and removed request for a team May 16, 2024 23:49
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 45.56962% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 90.85%. Comparing base (02d529e) to head (1d03614).
Report is 1 commits behind head on master.

Current head 1d03614 differs from pull request most recent head 1a1ea31

Please upload reports for the commit 1a1ea31 to get more accurate results.

Files Patch % Lines
dbldatagen/data_generator.py 60.00% 22 Missing and 2 partials ⚠️
dbldatagen/enhanced_event_time.py 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
- Coverage   92.14%   90.85%   -1.29%     
==========================================
  Files          23       24       +1     
  Lines        2788     2866      +78     
  Branches      477      491      +14     
==========================================
+ Hits         2569     2604      +35     
- Misses        130      171      +41     
- Partials       89       91       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant