Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature distribution changes - migrated tests to Pytest, use of abstract base classes #277

Merged
merged 4 commits into from
Jun 1, 2024

Conversation

ronanstokes-db
Copy link
Contributor

Proposed changes

Leverage abstract base classes in keeping with implementation of constraints, migrated tests to Pytest

Types of changes

What types of changes does your code introduce to dbldatagen?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to tutorials, tests or examples
  • Non code change (readme, images or other non-code assets)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Submission does not reduce code coverage numbers
  • Submission does not increase alerts or messages from prospector / lint

Further comments

Use of abstract base classes as general pattern for any pluggable aspects

@ronanstokes-db ronanstokes-db requested a review from a team as a code owner May 24, 2024 19:14
@ronanstokes-db ronanstokes-db requested review from GeekSheikh and removed request for a team May 24, 2024 19:14
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.59%. Comparing base (82ce5ce) to head (edc57c6).

Files Patch % Lines
dbldatagen/distributions/data_distribution.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   92.62%   92.59%   -0.04%     
==========================================
  Files          33       33              
  Lines        2998     2996       -2     
  Branches      523      522       -1     
==========================================
- Hits         2777     2774       -3     
- Misses        131      132       +1     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ronanstokes-db ronanstokes-db self-assigned this May 28, 2024
@ronanstokes-db ronanstokes-db added enhancement New feature or request code quality and removed enhancement New feature or request labels May 28, 2024
Copy link

@howardwu-db howardwu-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There is a codecov issue but dont know how you would test that

@ronanstokes-db ronanstokes-db merged commit 8136ccf into master Jun 1, 2024
4 of 5 checks passed
@ronanstokes-db ronanstokes-db deleted the feature_distribution_changes branch June 6, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants