-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test code and version support update #378
Test code and version support update #378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to agree on if we should be testing for Delta versions that support OPTIMIZE and Z-ORDER, as well as whether or not to use DBR for tox env names, before merging but otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing a lot of changes to the docs and other parts of the code not directly related to Tox and the test code. I suspect these might be from work-in-progress changes from another branch that got merged into your working branch @jtisbell4? In any event, let's clean this up so we're only making changes related to this particular update.
d006c22
to
7e5a5de
Compare
Apologies. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a few changes to io.py
- see inline comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
python/tests/requirements
SparkSession
initialization dynamic in test class setupTSDF.withRangeStats
event_time
column assumption and made Z-ORDER attempt contingent onoptimizationCols
inio.write