Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test code and version support update #378

Merged
merged 17 commits into from
Feb 28, 2024

Conversation

jtisbell4
Copy link
Contributor

@jtisbell4 jtisbell4 commented Jan 23, 2024

  • Reconfigured tox.ini
  • Moved DBR-specific requirements into python/tests/requirements
  • Made SparkSession initialization dynamic in test class setup
  • Fixed if statement in TSDF.withRangeStats
  • Removed event_time column assumption and made Z-ORDER attempt contingent on optimizationCols in io.write

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2024

CLA assistant check
All committers have signed the CLA.

@jtisbell4 jtisbell4 changed the base branch from dbr_test_coverage to master January 24, 2024 21:11
@jtisbell4 jtisbell4 changed the title Version support update Test code and version support update Jan 24, 2024
@jtisbell4 jtisbell4 marked this pull request as ready for review January 24, 2024 21:33
Copy link
Contributor

@R7L208 R7L208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to agree on if we should be testing for Delta versions that support OPTIMIZE and Z-ORDER, as well as whether or not to use DBR for tox env names, before merging but otherwise LGTM

python/tempo/io.py Outdated Show resolved Hide resolved
python/tests/io_tests.py Outdated Show resolved Hide resolved
python/tox.ini Show resolved Hide resolved
Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing a lot of changes to the docs and other parts of the code not directly related to Tox and the test code. I suspect these might be from work-in-progress changes from another branch that got merged into your working branch @jtisbell4? In any event, let's clean this up so we're only making changes related to this particular update.

@jtisbell4
Copy link
Contributor Author

I'm seeing a lot of changes to the docs and other parts of the code not directly related to Tox and the test code. I suspect these might be from work-in-progress changes from another branch that got merged into your working branch @jtisbell4? In any event, let's clean this up so we're only making changes related to this particular update.

Apologies. Fixed.

@jtisbell4 jtisbell4 requested a review from tnixon January 25, 2024 16:23
Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a few changes to io.py - see inline comments

python/tempo/io.py Outdated Show resolved Hide resolved
python/tempo/io.py Outdated Show resolved Hide resolved
python/tempo/io.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnixon tnixon merged commit 480299b into databrickslabs:master Feb 28, 2024
5 of 8 checks passed
tnixon added a commit that referenced this pull request Feb 28, 2024
tnixon added a commit that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants