Skip to content

Commit

Permalink
Set back disable too-many-public-methods
Browse files Browse the repository at this point in the history
  • Loading branch information
JCZuurmond committed Dec 6, 2024
1 parent c24fcd9 commit 638c3e2
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 6 deletions.
3 changes: 1 addition & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -600,8 +600,7 @@ disable = [
"consider-using-any-or-all",
"too-many-positional-arguments",
"unnecessary-default-type-args",
"logging-not-lazy",
"too-many-public-methods", # TODO: Remove by someone who can bypass CI cheat linter check
"logging-not-lazy"
]

# Enable the message, report, category or checker with the given id(s). You can
Expand Down
2 changes: 1 addition & 1 deletion src/databricks/labs/ucx/assessment/workflows.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
logger = logging.getLogger(__name__)


class Assessment(Workflow):
class Assessment(Workflow): # pylint: disable=too-many-public-methods
def __init__(self):
super().__init__('assessment')

Expand Down
1 change: 1 addition & 0 deletions src/databricks/labs/ucx/contexts/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@
# used throughout the application. That being said, we'll do best
# effort of splitting the instances between Global, Runtime,
# Workspace CLI, and Account CLI contexts.
# pylint: disable=too-many-public-methods

logger = logging.getLogger(__name__)

Expand Down
1 change: 1 addition & 0 deletions src/databricks/labs/ucx/contexts/workflow_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
from databricks.labs.ucx.progress.workflow_runs import WorkflowRunRecorder

# As with GlobalContext, service factories unavoidably have a lot of public methods.
# pylint: disable=too-many-public-methods


class RuntimeContext(GlobalContext):
Expand Down
2 changes: 2 additions & 0 deletions src/databricks/labs/ucx/contexts/workspace_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@

logger = logging.getLogger(__name__)

# pylint: disable=too-many-public-methods


class WorkspaceContext(CliContext):
def __init__(self, ws: WorkspaceClient, named_parameters: dict[str, str] | None = None):
Expand Down
2 changes: 1 addition & 1 deletion src/databricks/labs/ucx/hive_metastore/tables.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class AclMigrationWhat(Enum):


@dataclass
class Table:
class Table: # pylint: disable=too-many-public-methods
catalog: str
database: str
name: str
Expand Down
2 changes: 1 addition & 1 deletion src/databricks/labs/ucx/source_code/python/python_ast.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def first_statement(self) -> NodeNG | None:
return self.tree.first_statement()


class Tree:
class Tree: # pylint: disable=too-many-public-methods

@classmethod
def maybe_parse(cls, code: str) -> MaybeTree:
Expand Down
4 changes: 3 additions & 1 deletion tests/integration/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,9 @@ def workspace_client(self) -> WorkspaceClient:
return self._ws


class MockRuntimeContext(CommonUtils, RuntimeContext): # pylint: disable=too-many-instance-attributes
class MockRuntimeContext(
CommonUtils, RuntimeContext
): # pylint: disable=too-many-instance-attributes,too-many-public-methods
def __init__( # pylint: disable=too-many-arguments
self,
make_catalog_fixture,
Expand Down

0 comments on commit 638c3e2

Please sign in to comment.