[BUG]: estimates_report run fails on non uc enabled workspaces

[rkkalluri]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

Looks like this is a new task added to UCX assessment and it fails when workspace is not uc enabled

Expected Behavior

UCX assessment is mostly run before a metastore is assigned in general cases. We should provide an option to make this optional or skip it if workspace is not uc enabled.

Steps To Reproduce

No response

Cloud

Azure

Operating System

Windows

Version

latest via Databricks CLI

Relevant log output

No response

[nfx]

@rkkalluri insufficient information. need logs to further diagnose.

[mohanab-db]

@nfx I have also seen the same issue. The assessment task estimates_report fails if a metastore is not assigned to the workspace. This task is refreshing a dashboard 'UCX] UCX Assessment (Estimates)'. Only one query fails.
SELECT case when CURRENT_METASTORE() is not null then "Metastore already assigned" else "Metastore not assigned" end as uc_metastore_assigned
That's because the inbuilt function CURRENT_METASTORE() (instead of returning null, which the code is expecting) throws an error if a metastore is not assigned.
[OPERATION_REQUIRES_UNITY_CATALOG] Operation CURRENT_METASTORE requires Unity Catalog enabled.
SQL file path - /ucx/src/databricks/labs/ucx/queries/assessment/estimates/00_2_is_metastore_assigned.sql

[qziyuan]

There is not a good solution for a DBSQL query to tell if the workspace is UC enabled or not. For now we have to bear with this error, but the document should be improved to notice this behavior.

[nfx]

@ericvergnaud nouc-workspace is labs-azure-admin (via labs CLI)

[rkkalluri]

What roles are expected in Azure subscriptions by these ucx commands. It is better to document them instead of arriving by trial and error. Hopefully it is not global admin as that is not a reality in the enterprise.

…

On Tue, May 7, 2024, 5:03 AM Serge Smertin ***@***.***> wrote: @ericvergnaud <https://github.com/ericvergnaud> nouc-workspace is labs-azure-admin (via labs CLI) — Reply to this email directly, view it on GitHub <#1112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZ6RLADEBRBBBS7YBY4PETZBCRHDAVCNFSM6AAAAABFHMAJQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJXHEZDKNZSGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ericvergnaud]

@rkkalluri I'm looking to fix this issue, but there seems to be quite a gap between this thread and the latest code since the above problematic query is no longer available in the code base. I'm wondering if this bug might already be fixed ? Can you check ?

[ericvergnaud]

@rkkalluri any update ? Or should we close this issue ?

[rkkalluri]

We can close this, it seems to be fixed at the moment

…

On Mon, May 27, 2024, 3:46 AM Eric Vergnaud ***@***.***> wrote: @rkkalluri <https://github.com/rkkalluri> any update ? Or should we close this issue ? — Reply to this email directly, view it on GitHub <#1112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZ6RLC565Q4JBM5HS6NXR3ZELXFLAVCNFSM6AAAAABFHMAJQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZSHE3TKNRVHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ericvergnaud]

Thanks @rkkalluri