Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor installer to separate workflows methods from the installer class #1055

Merged
merged 27 commits into from
Mar 21, 2024
Merged

Refactor installer to separate workflows methods from the installer class #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
1c5854c
Worked on Skeleton
FastLee Mar 14, 2024
0efae46
Addressed all issues
FastLee Mar 14, 2024
eabef09
Fixed unit tests
FastLee Mar 14, 2024
2fc4622
Addressed FMT errors and unit tests
FastLee Mar 14, 2024
3cb8d0e
Increased test coverage.
FastLee Mar 14, 2024
b62c833
Increased test coverage.
FastLee Mar 14, 2024
16fcbe3
Addressed timeout issues
FastLee Mar 15, 2024
981bd20
Addressed timeout issues
FastLee Mar 17, 2024
b96f561
Addressed timeout issues
FastLee Mar 17, 2024
eb80cfe
Addressed timeout issues
FastLee Mar 17, 2024
5ce3aa5
Addressed timeout issues
FastLee Mar 18, 2024
386143a
Fixed new test
FastLee Mar 18, 2024
5740f5d
Fixed new test
FastLee Mar 18, 2024
0be17bf
Addressed testing issue
FastLee Mar 18, 2024
6ac7f8f
Addressed FMT issues
FastLee Mar 18, 2024
e1f619f
Addressed testing issue
FastLee Mar 18, 2024
cf68094
Addressed testing issue
FastLee Mar 18, 2024
d16708e
Added code coverage
FastLee Mar 19, 2024
a671237
Added code coverage
FastLee Mar 19, 2024
4950718
Added code coverage
FastLee Mar 19, 2024
8e978f9
Addressed Integration Test
FastLee Mar 19, 2024
45122d3
Addressed Integration Test Issue
FastLee Mar 20, 2024
33a445d
Fixed job clusters
FastLee Mar 20, 2024
fc444c5
Fixed job clusters
FastLee Mar 20, 2024
88553e5
Addressed Integration Test
FastLee Mar 20, 2024
31e95ac
Fixed rebase issues
FastLee Mar 20, 2024
35dcb00
Increased coverage
FastLee Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/databricks/labs/ucx/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from databricks.labs.ucx.hive_metastore.table_migrate import TablesMigrate
from databricks.labs.ucx.hive_metastore.table_move import TableMove
from databricks.labs.ucx.install import WorkspaceInstallation
from databricks.labs.ucx.installer.workflows import WorkflowsInstallation
from databricks.labs.ucx.workspace_access.clusters import ClusterAccess
from databricks.labs.ucx.workspace_access.groups import GroupManager

Expand All @@ -41,7 +42,7 @@
@ucx.command
def workflows(w: WorkspaceClient):
"""Show deployed workflows and their state"""
installation = WorkspaceInstallation.current(w)
installation = WorkflowsInstallation.current(w)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
installation = WorkflowsInstallation.current(w)
installation = Workflows.current(w)

logger.info("Fetching deployed jobs...")
print(json.dumps(installation.latest_job_status()))

Expand Down Expand Up @@ -162,7 +163,7 @@ def repair_run(w: WorkspaceClient, step):
"""Repair Run the Failed Job"""
if not step:
raise KeyError("You did not specify --step")
installation = WorkspaceInstallation.current(w)
installation = WorkflowsInstallation.current(w)
logger.info(f"Repair Running {step} Job")
installation.repair_run(step)

Expand Down
Loading
Loading