Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create
method of the_policy_installer
object has been updated to return an additional value,instance_pool_id
, which is then assigned and passed as an argument to theWorkspaceConfig
object in the_configure_new_installation
method. TheClusterPolicyInstaller
class in thev0.15.0_added_cluster_policy.py
file has also been updated to return a fourth value,instance_pool_id
, from thecreate
method, allowing for more flexibility in future enhancements. Additionally, the test functiontest_table_migration_job
in thetest_installation.py
file has been updated to skip when the script is not being run as part of a nightly test job or in debug mode, and the test functions in thetest_policy.py
file have been updated to reflect the new return value in thecreate
method. These changes enable better management and scaling of resources through instance pools, provide more granular control in the WorkspaceConfig, and improve testing efficiency.migrate-locations
andvalidate_external_locations
commands to use the correct syntax, enclosing them in backticks to denote code. This change ensures that the links are correctly interpreted as commands and addresses any issues that may have arisen with their previous formatting. It is important to note that no new methods have been added in this release, and the existing functionality of the commands has not been changed in scope or functionality.create_account_group
command related to theworkspace_ids
flag in our open-source library. Theworkspace_ids
flag's type has been changed fromlist[int] | None
tostr | None
, allowing for easier input of multiple workspace IDs as a string of comma-separated integers. Thecreate_account_level_groups
function in theAccountWorkspaces
class has been updated to accept this string and convert it to a list of integers before proceeding. To ensure proper functioning, we added a new test casetest_create_account_groups_with_id()
to check if the command handles the case when no workspace IDs are provided in the configuration. Thecreate_account_groups()
method now checks for this condition and raises aValueError
. Furthermore, themanual_workspace_info()
method has been updated to handle workspace name input by the user, receiving thews
object, along with prompts that contain the user input for the workspace name and the next workspace ID._definition
function, which has been modified to use the latest LTS DBR instead of the latest Spark version. Thelatest_lts_dbr
variable is now assigned the value returned by theselect_spark_version
method with thelatest=True
andlong_term_support=True
parameters. Thespark_version
key in thepolicy_definition
dictionary is set to the value returned by the_policy_config
method withlatest_lts_dbr
as the argument. Additionally, in thetests/unit/installer/test_policy.py
file, theselect_spark_version
method of theclusters
object has been updated to accept any number of arguments and consistently return the string "14.2.x-scala2.12", allowing for greater flexibility. This is a temporary solution, with a more comprehensive fix being tracked in issue #1098. Developers should be aware of how theclusters
object is used in the codebase when adopting this project.