Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix random test group names with capital G #1646

Merged
merged 1 commit into from
May 7, 2024

Conversation

JCZuurmond
Copy link
Member

@JCZuurmond JCZuurmond commented May 7, 2024

Changes

Similarly to the prefix catalogs with "C", tables with "T" and schemas with "S", also prefix random test group names with "G".

Linked issues

Hopefully it narrows the KeyError in: #1616

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs ucx ...
  • added a new workflow
  • modified existing workflow: ...
  • added a new table
  • modified existing table: ...

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • verified on staging environment (screenshot attached)

@JCZuurmond JCZuurmond requested review from a team and andrascsillag-db May 7, 2024 09:45
@JCZuurmond JCZuurmond requested a review from nkvuong May 7, 2024 09:45
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (e3bdd3d) to head (fe32a43).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1646   +/-   ##
=======================================
  Coverage   90.10%   90.10%           
=======================================
  Files          86       86           
  Lines       10568    10568           
  Branches     1863     1863           
=======================================
  Hits         9522     9522           
  Misses        684      684           
  Partials      362      362           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nkvuong nkvuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nkvuong nkvuong enabled auto-merge May 7, 2024 10:00
Copy link

github-actions bot commented May 7, 2024

✅ 160/160 passed, 25 skipped, 2h31m30s total

Running from acceptance #2996

@nkvuong nkvuong added this pull request to the merge queue May 7, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 7, 2024
## Changes
Similarly to the prefix catalogs with "C", tables with "T" and schemas
with "S", also prefix random test group names with "G".

### Linked issues
Hopefully it narrows the KeyError in: #1616

### Functionality 

- [ ] added relevant user documentation
- [ ] added new CLI command
- [ ] modified existing command: `databricks labs ucx ...`
- [ ] added a new workflow
- [ ] modified existing workflow: `...`
- [ ] added a new table
- [ ] modified existing table: `...`

### Tests
<!-- How is this tested? Please see the checklist below and also
describe any other relevant tests -->

- [ ] manually tested
- [ ] added unit tests
- [ ] added integration tests
- [ ] verified on staging environment (screenshot attached)
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 7, 2024
@JCZuurmond JCZuurmond added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 0a47514 May 7, 2024
8 checks passed
@JCZuurmond JCZuurmond deleted the prefix-test-group-with-g branch May 7, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants