EditorConfig specification for the project and minor tooling improvements #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These settings match the project settings.
|
|
nfx
reviewed
May 27, 2024
| [*] | ||
| indent_style = space | ||
| indent_size = 4 | ||
| tab_width = 8 |
There was a problem hiding this comment.
Suggested change
| tab_width = 8 | |
| tab_width = 4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1778 +/- ##
=======================================
Coverage 89.64% 89.64%
=======================================
Files 95 95
Lines 11748 11748
Branches 2058 2058
=======================================
Hits 10532 10532
Misses 819 819
Partials 397 397 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Serge Smertin <259697+nfx@users.noreply.github.com>
asnare
changed the title
nfx
changed the title
Merged
nfx
pushed a commit
that referenced
this pull request
Jul 5, 2024
## Changes This PR follows on from #1778 by cleaning up files that use tabs, have trailing whitespace, or are missing EOL at the end of files. By fixing these in one go other PRs become less noisy. (Sample files used in tests have been left alone and are not affected by this PR.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR includes some trivial repository updates:
make verifytarget is eliminated.Makefiletargets are now marked as phony, which is more of a hygiene thing than anything else.Tests