Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cater for empty python cells #3212

Merged
merged 1 commit into from
Nov 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/databricks/labs/ucx/source_code/notebooks/sources.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,12 @@ def _load_tree_from_python_cell(self, python_cell: PythonCell, register_trees: b
maybe_tree = Tree.maybe_normalized_parse(python_cell.original_code)
if maybe_tree.failure:
yield maybe_tree.failure
assert maybe_tree.tree is not None
tree = maybe_tree.tree
# a cell with only comments will not produce a tree
if register_trees:
self._python_trees[python_cell] = tree
self._python_trees[python_cell] = tree or Tree.new_module()
if not tree:
return
yield from self._load_children_from_tree(tree)

def _load_children_from_tree(self, tree: Tree) -> Iterable[Advice]:
Expand Down