Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sqlglot requirement from <26.7,>=25.5.0 to >=25.5.0,<26.8 #3766

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 26, 2025

Updates the requirements on sqlglot to permit the latest version.

Changelog

Sourced from sqlglot's changelog.

[v26.7.0] - 2025-02-26

💥 BREAKING CHANGES

... (truncated)

Commits
  • e9c8eae Chore!: bump sqlglotrs to 0.4.0
  • fe171e8 Revert "Fix(optimizer)!: parse unqualified names in DISTINCT ON (...) as iden...
  • 856faa9 Feat(mysql): add support for ALTER INDEX (#4800)
  • 575c979 feat(clickhouse): support GLOBAL NOT IN (#4798)
  • e05983a Fix(tokenizer-rs)!: make hex literal tokenization more robust (#4802)
  • a9ae2d2 fix(tsql)!: support TOP with PERCENT and WITH TIES (#4801)
  • 9f6b4f7 Fix(snowflake): add missing clauses in SHOW statements (#4797)
  • 513fad4 feat(snowflake)!: show databases, functions, procedures and warehouses (#4787)
  • 00c7f05 Fix(optimizer)!: do not coerce parameterized types (#4796)
  • 14c3de9 Fix(optimizer)!: parse unqualified names in DISTINCT ON (...) as identifiers ...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [sqlglot](https://github.com/tobymao/sqlglot) to permit the latest version.
- [Changelog](https://github.com/tobymao/sqlglot/blob/main/CHANGELOG.md)
- [Commits](tobymao/sqlglot@v25.5.0...v26.7.0)

---
updated-dependencies:
- dependency-name: sqlglot
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner February 26, 2025 15:13
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Feb 26, 2025
@JCZuurmond
Copy link
Member

Superseded by #3799

@JCZuurmond JCZuurmond closed this Feb 28, 2025
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 28, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/sqlglot-gte-25.5.0-and-lt-26.8 branch February 28, 2025 09:16
github-merge-queue bot pushed a commit that referenced this pull request Feb 28, 2025
## Changes
Pin dependencies to minor releases to test dependency changes before
users are affected by them.

The reasoning for choosing between pinned vs loose requirements is:
1. For applications (like UCX), pin the dependency minor versions to
minimize instability due to changes in dependencies while still
receiving dependency bug/patch fixes. We automatically test dependency
changes in Dependabot's PRs.
2. For libraries (like pytest, lsql and blueprint), prefer loose
requirements so that the libraries and projects that use your library
have the freedom to chose their preferred version, especially important
to increase the likelihood for finding a library version that fits the
constrains of all dependencies and sub-dependencies (dependencies of
dependencies of dependencies ...).

We prefer the greater than or equal to & lower than syntax over the
tilde as it is more clear what the version range is

The sdk version pinning is covered by #3686
Supersedes #3766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant