Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed legacy table ACL ownership migration and other integration testing issues #722

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

nfx
Copy link
Collaborator

@nfx nfx commented Dec 21, 2023

Close #717

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (8b2c72d) 79.59% compared to head (73f983e) 79.37%.

Files Patch % Lines
src/databricks/labs/ucx/install.py 52.63% 22 Missing and 5 partials ⚠️
src/databricks/labs/ucx/workspace_access/groups.py 60.00% 3 Missing and 1 partial ⚠️
src/databricks/labs/ucx/cli.py 0.00% 2 Missing ⚠️
src/databricks/labs/ucx/framework/parallel.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
- Coverage   79.59%   79.37%   -0.23%     
==========================================
  Files          42       42              
  Lines        4401     4407       +6     
  Branches      814      816       +2     
==========================================
- Hits         3503     3498       -5     
- Misses        689      697       +8     
- Partials      209      212       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfx nfx merged commit 8aed930 into main Dec 21, 2023
4 of 7 checks passed
@nfx nfx deleted the chore/integration-tests branch December 21, 2023 23:16
@nfx nfx mentioned this pull request Dec 21, 2023
nfx added a commit that referenced this pull request Dec 21, 2023
* Added `databricks labs ucx create-table-mapping` and `databricks labs ucx manual-workspace-info` commands for CLI ([#682](#682)).
* Added `databricks labs ucx ensure-assessment-run` to CLI commands ([#708](#708)).
* Added `databricks labs ucx installations` command ([#679](#679)).
* Added `databricks labs ucx skip --schema ... --table ...` command to mark table/schema for skipping in the table migration process ([#680](#680)).
* Added `databricks labs ucx validate-external-locations` command for cli ([#715](#715)).
* Added capturing `ANY FILE` and `ANONYMOUS FUNCTION` grants ([#653](#653)).
* Added cluster override and handle case of write protected DBFS ([#610](#610)).
* Added cluster policy selector in the installer ([#655](#655)).
* Added detailed UCX pre-requisite information to README.md ([#689](#689)).
* Added interactive wizard for `databricks labs uninstall ucx` command ([#657](#657)).
* Added more granular error retry logic ([#704](#704)).
* Added parallel fetching of registered model identifiers to speed-up assessment workflow ([#691](#691)).
* Added retry on workspace listing ([#659](#659)).
* Added support for mapping workspace group to account group by prefix/suffix/regex/external id ([#650](#650)).
* Changed cluster security mode from NONE to LEGACY_SINGLE_USER, as `crawl_tables` was failing when run on non-UC Workspace in No Isolation mode with unable to access the config file ([#661](#661)).
* Changed the fields of the table "Tables" to lower case ([#684](#684)).
* Enabled integration tests for `EXTERNAL` table migrations ([#677](#677)).
* Enforced `mypy` validation ([#713](#713)).
* Filtering out inventory database from loading into tables and filtering out the same from grant detail view ([#705](#705)).
* Fixed documentation for `reflect_account_groups_on_workspace` task and updated `CONTRIBUTING.md` guide ([#654](#654)).
* Fixed secret scope apply task to raise ValueError ([#683](#683)).
* Fixed legacy table ACL ownership migration and other integration testing issues ([#722](#722)).
* Fixed some flaky integration tests ([#700](#700)).
* New CLI command for workspace mapping ([#678](#678)).
* Reduce server load for getting workspace groups and their members ([#666](#666)).
* Throwing ManyError on migrate-groups tasks ([#710](#710)).
* Updated installation documentation to use Databricks CLI ([#686](#686)).

Dependency updates:

 * Updated databricks-sdk requirement from ~=0.13.0 to ~=0.14.0 ([#651](#651)).
 * Updated databricks-sdk requirement from ~=0.14.0 to ~=0.15.0 ([#687](#687)).
 * Updated databricks-sdk requirement from ~=0.15.0 to ~=0.16.0 ([#712](#712)).
nfx added a commit that referenced this pull request Dec 21, 2023
* Added `databricks labs ucx create-table-mapping` and `databricks labs
ucx manual-workspace-info` commands for CLI
([#682](#682)).
* Added `databricks labs ucx ensure-assessment-run` to CLI commands
([#708](#708)).
* Added `databricks labs ucx installations` command
([#679](#679)).
* Added `databricks labs ucx skip --schema ... --table ...` command to
mark table/schema for skipping in the table migration process
([#680](#680)).
* Added `databricks labs ucx validate-external-locations` command for
cli ([#715](#715)).
* Added capturing `ANY FILE` and `ANONYMOUS FUNCTION` grants
([#653](#653)).
* Added cluster override and handle case of write protected DBFS
([#610](#610)).
* Added cluster policy selector in the installer
([#655](#655)).
* Added detailed UCX pre-requisite information to README.md
([#689](#689)).
* Added interactive wizard for `databricks labs uninstall ucx` command
([#657](#657)).
* Added more granular error retry logic
([#704](#704)).
* Added parallel fetching of registered model identifiers to speed-up
assessment workflow
([#691](#691)).
* Added retry on workspace listing
([#659](#659)).
* Added support for mapping workspace group to account group by
prefix/suffix/regex/external id
([#650](#650)).
* Changed cluster security mode from NONE to LEGACY_SINGLE_USER, as
`crawl_tables` was failing when run on non-UC Workspace in No Isolation
mode with unable to access the config file
([#661](#661)).
* Changed the fields of the table "Tables" to lower case
([#684](#684)).
* Enabled integration tests for `EXTERNAL` table migrations
([#677](#677)).
* Enforced `mypy` validation
([#713](#713)).
* Filtering out inventory database from loading into tables and
filtering out the same from grant detail view
([#705](#705)).
* Fixed documentation for `reflect_account_groups_on_workspace` task and
updated `CONTRIBUTING.md` guide
([#654](#654)).
* Fixed secret scope apply task to raise ValueError
([#683](#683)).
* Fixed legacy table ACL ownership migration and other integration
testing issues ([#722](#722)).
* Fixed some flaky integration tests
([#700](#700)).
* New CLI command for workspace mapping
([#678](#678)).
* Reduce server load for getting workspace groups and their members
([#666](#666)).
* Throwing ManyError on migrate-groups tasks
([#710](#710)).
* Updated installation documentation to use Databricks CLI
([#686](#686)).

Dependency updates:

* Updated databricks-sdk requirement from ~=0.13.0 to ~=0.14.0
([#651](#651)).
* Updated databricks-sdk requirement from ~=0.14.0 to ~=0.15.0
([#687](#687)).
* Updated databricks-sdk requirement from ~=0.15.0 to ~=0.16.0
([#712](#712)).
FastLee pushed a commit that referenced this pull request Jan 19, 2024
FastLee pushed a commit that referenced this pull request Jan 19, 2024
* Added `databricks labs ucx create-table-mapping` and `databricks labs
ucx manual-workspace-info` commands for CLI
([#682](#682)).
* Added `databricks labs ucx ensure-assessment-run` to CLI commands
([#708](#708)).
* Added `databricks labs ucx installations` command
([#679](#679)).
* Added `databricks labs ucx skip --schema ... --table ...` command to
mark table/schema for skipping in the table migration process
([#680](#680)).
* Added `databricks labs ucx validate-external-locations` command for
cli ([#715](#715)).
* Added capturing `ANY FILE` and `ANONYMOUS FUNCTION` grants
([#653](#653)).
* Added cluster override and handle case of write protected DBFS
([#610](#610)).
* Added cluster policy selector in the installer
([#655](#655)).
* Added detailed UCX pre-requisite information to README.md
([#689](#689)).
* Added interactive wizard for `databricks labs uninstall ucx` command
([#657](#657)).
* Added more granular error retry logic
([#704](#704)).
* Added parallel fetching of registered model identifiers to speed-up
assessment workflow
([#691](#691)).
* Added retry on workspace listing
([#659](#659)).
* Added support for mapping workspace group to account group by
prefix/suffix/regex/external id
([#650](#650)).
* Changed cluster security mode from NONE to LEGACY_SINGLE_USER, as
`crawl_tables` was failing when run on non-UC Workspace in No Isolation
mode with unable to access the config file
([#661](#661)).
* Changed the fields of the table "Tables" to lower case
([#684](#684)).
* Enabled integration tests for `EXTERNAL` table migrations
([#677](#677)).
* Enforced `mypy` validation
([#713](#713)).
* Filtering out inventory database from loading into tables and
filtering out the same from grant detail view
([#705](#705)).
* Fixed documentation for `reflect_account_groups_on_workspace` task and
updated `CONTRIBUTING.md` guide
([#654](#654)).
* Fixed secret scope apply task to raise ValueError
([#683](#683)).
* Fixed legacy table ACL ownership migration and other integration
testing issues ([#722](#722)).
* Fixed some flaky integration tests
([#700](#700)).
* New CLI command for workspace mapping
([#678](#678)).
* Reduce server load for getting workspace groups and their members
([#666](#666)).
* Throwing ManyError on migrate-groups tasks
([#710](#710)).
* Updated installation documentation to use Databricks CLI
([#686](#686)).

Dependency updates:

* Updated databricks-sdk requirement from ~=0.13.0 to ~=0.14.0
([#651](#651)).
* Updated databricks-sdk requirement from ~=0.14.0 to ~=0.15.0
([#687](#687)).
* Updated databricks-sdk requirement from ~=0.15.0 to ~=0.16.0
([#712](#712)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant