diff is breaking for specific checks performed by bitnami/common

[morremeyer]

The plugin fails for a specific configuration (maybe a specific template function?) that is used in the bitnami/common chart.

It specifically leads to these bitnami charts displaying an error message on diff that certain credentials (e.g. for bitnami/mysql and bitnami/postgresql) need to be specified when upgrading, although they are set correctly.

This is evidenced by helm upgrade working with the same configuration without any issues (same goes for helmfile).

This was discovered in bitnami/charts#15073, but also mentioned by me in bitnami/charts#15175.

Specifically, the configuration mentioned in bitnami/charts#15175 (comment) shows the error mentioned there.

Tracing this down to its source, it seems to be happening when the following line is hit: https://github.com/bitnami/charts/blob/d8211ca955bae990f4b1af121419545cb90309eb/bitnami/common/templates/_secrets.tpl#L93 (see bitnami/charts#15175 (comment)).

I deduced this from the error message in line 111 being triggered: https://github.com/bitnami/charts/blob/d8211ca955bae990f4b1af121419545cb90309eb/bitnami/common/templates/_secrets.tpl#L111, which needs the template to fall into the else clause in https://github.com/bitnami/charts/blob/d8211ca955bae990f4b1af121419545cb90309eb/bitnami/common/templates/_secrets.tpl#L102.

This should not happen since https://github.com/bitnami/charts/blob/d8211ca955bae990f4b1af121419545cb90309eb/bitnami/common/templates/_secrets.tpl#L93 resolves to a secret being set and therefore the if in https://github.com/bitnami/charts/blob/d8211ca955bae990f4b1af121419545cb90309eb/bitnami/common/templates/_secrets.tpl#L94 should be entered.

I'm aware that this is a very unspecific report, please let me know if I should provide an easier reproduction scenario or similar.

[gldkru]

Can this problem be solved?

[morremeyer]

@gldkru Is this a request to the maintainers to fix this or a question if it is technically possible to solve this?

[gldkru]

@morremeyer I want to solve this problem for myself and I found only this issue

[NfNitLoop]

I'm experiencing the same issue in bitnami/charts#17717. Our workaround has been to stop using helm diff. (or, more specifically, start using helmfile sync instead of helmfile apply.)

We'd like to be able to use helm-diff for these charts, though. If anyone knows of a fix in helm-diff or can help the bitnami folks make their charts compatible with helm-diff, we'd definitely prefer to use helm diff in our workflow! ❤️

[gz243]

We are encountering the same issue here. This is preventing us from using this plugin since we use quite a few Bitnami charts.

[jkroepke]

What happens, if you pre-define the password on values and let them not generate through helm chart?

There are various additional issues, since helm diff uses helm template in background. And helm template does not support lookup by design.

The only way that I can see there is not using helm to generate a password.

[morremeyer]

@jkroepke I'm not generating the password values with the chart, I'm specifying them in a secret and referencing that.

As you noted, it looks like the lookup in that secret is breaking.

Do I understand your comment correctly that helm template should show the name failure mode here?

If that's the case, I assume we can reproduce it independently from helm diff.

[jkroepke]

Yes. ArgoCD has the same issue, because ArgoCD depends on helm template, too.

helm/helm#8137

But a fix seems to be merged 2 days ago on helm directly. helm/helm#9426

If a new helm version released and helm diff includes the new helm version, it cloud resolve the issue here, too.

[morremeyer]

ArgoCD having the same issue is interesting, I know of a case where the issue went away when migrating from helmfile to ArgoCD.

However, it's amazing news that there is a fix in helm itself for this.
Thanks for tying all the loose ends together here, @jkroepke!

I'll check if this is still an issue with the next helm release, will update here once I find out.

[jkroepke]

ArgoCD ref: argoproj/argo-cd#5202

[acascais]

We're having the same problem with the bitnami postgres helm chart: helmfile diff fails, helmfile sync works fine.

Is there a fix for this?

[NeonSludge]

Still breaking with latest helm-diff and Helm 3.14.

Correction: still breaking for tools that do not use dry-run=server.