Support the upgrade flag --reset-then-reuse-values added in Helm v3.14.0 #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag was added in Helm v3.14.0; for details see helm/helm#9653.
|
Hey @yxxhero 👋 Do you think we can have this merged if everything's all right? |
|
@trk9001 I will review at weekend. |
yxxhero
reviewed
Jul 4, 2024
yxxhero
reviewed
Jul 26, 2024
|
@trk9001 any tests? |
Not sure how I can test the new functionality without a remote cluster, although I did test it manually with a cluster I have access to. Any suggestions? |
yxxhero
reviewed
Jul 31, 2024
|
@yxxhero I'm not sure that there is anything left to do here with regard to testing. If you also agree, then can we have this merged? |
|
@mumoshu WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this flag was added to Helm it has made life much easier when upgrading charts with multiple values files. By force of habit I run
helm diff upgradebefore nearly everyhelm upgrade, so it's a bummer when this flag isn't recognized. This PR adds support for it and closes #571.PS. I'm very new to Go, and it probably shows in the effort. I'd appreciate any pointers to improve the code, or any suggestions in general. Thanks!