Add $schema to ecs.json and .circleci/config.yml #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a $schema in json files has a bunch of benefits, mostly because of language servers (json-languages-server and yaml-language-server). These are automatically setup in VSCode and easy to set up for other editors.
Result of linting ecs.json files for this repo:
Note that healtCheck is now a required property, if you have a containerPort defined. See https://datacamp.atlassian.net/wiki/spaces/PRODENG/pages/25690481/ecs.json+reference for more info.
Note that you might have a literal "${VARIABLE}" in you ecs.json that still gets replaced at build time to create a valid ecs.jon which might complain in your editor but is not shown above