Issue169 #183
Merged
Issue169 #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <strong><%= exampleUser.username %></strong> | ||
| at | ||
| <div class="example-wrapper"> | ||
| <% if(reviewTarget!==null){ %> |
There was a problem hiding this comment.
maybe rename this exampleTarget, since it is not related to review anymore
|
Can you rebase it when you've done all the changes, so I can merge it ? |
louisdelanoeye
force-pushed
the
issue169
branch
from
290adfc to
754e12d
Compare
louisdelanoeye
force-pushed
the
issue169
branch
from
754e12d to
24c501b
Compare
| @@ -126,6 +126,8 @@ module.exports.routes = { | |||
| // API | |||
| 'get /api/topics/:topicId/examples': 'ExampleController.findByTopic', | |||
| 'post /api/topics/:topicId/examples': 'ExampleController.postExampleToTopic', | |||
| 'post /api/:exampleId/remove': 'ExampleController.deleteExample', | |||
| 'post /api/:exampleId/update': 'ExampleController.updateExample', | |||
There was a problem hiding this comment.
@louisdelanoeye
So the route looks like this: /api/1/remove ?
It's not clear that we deal with examples.
I would rename theses routes like this:
delete /api/examples/:exampleId': 'ExampleController.deleteExample
post /api/examples/:exampleId': 'ExampleController.updateExample
No need for the /remove and /update the http method tells us the action to do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added delete and modify button to examples