Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce POLYGON for proper motions, requires new operator POLYGON_PROPER_MOTIONS #145

Open
HannoSpreeuw opened this issue Jul 15, 2022 · 0 comments
Labels
status:wait Progress dependent on another issue or conversation

Comments

@HannoSpreeuw
Copy link

The original Transform and Select chapter contained a beautiful application of the convex hull algorithm from Scipy.
This was used to derive a polygon which could be included in an ADQL query to select stars based on their proper motions.
However, POLYGON from ADQL is not meant to select based on proper motions, it should only be applied to positions on the sky.

Therefore it has recently been replaced by two BETWEEN operators

POLYGON for proper motions will still work in our case, with this trick

AND 1 = CONTAINS(POINT(-pmra, -pmdec),
                   POLYGON({negative_pm_point_list})) 

But that will not work in all cases, as @abostroem pointed out, so is not recommended.
At this point the two BETWEEN operators are the best we can do, it seems.

But I would like to reintroduce the convex hull and more elegant selection of stars based on proper motions as soon as something like a POLYGON_PROPER_MOTIONS operator has been built.

Hopefully VO people will build such an operator in the near future.

@eteq, @abostroem mentioned your name in the Slack channel, could you please keep us updated on any developments with respect to this matter?

@abostroem abostroem added the status:wait Progress dependent on another issue or conversation label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:wait Progress dependent on another issue or conversation
Projects
None yet
Development

No branches or pull requests

2 participants