Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify issues links in CONTRIBUTING.md #205

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

JCSzamosi
Copy link
Contributor

This pull request is being submitted to all repos that have been converted to Workbench, so that they reflect a recent update in the Workbench template. The change is probably appropriate for your repository, but you may disagree. I encourage you to look at a description of the problem it fixes found in this comment of this issue.

You will still need to replace example.com/FIXME in the [repo] and [repo-issues] link targets with this repository.

It additionally fixes the broken [how-contribute] link.

@github-actions
Copy link

github-actions bot commented Jun 12, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/astronomy-python/compare/md-outputs..md-outputs-PR-205

The following changes were observed in the rendered markdown documents:


What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-09-11 15:09:32 +0000

github-actions bot pushed a commit that referenced this pull request Jun 12, 2023
Copy link
Contributor

@astroDimitrios astroDimitrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we still need to fix the FIXME links as mentioned but I will fix this on merge.

@astroDimitrios astroDimitrios merged commit 0661c5d into datacarpentry:main Sep 11, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants