Skip to content

Update 01-query.md #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update 01-query.md #246

wants to merge 1 commit into from

Conversation

ShebMichel
Copy link
Contributor

query2_erroneous ="""SELECT
TOP 3000
WHERE parallax < 1
source_id, ref_epoch, ra, dec, parallax
FROM gaiadr2.gaia_source
""" The top query is wrong and have been replaced by this: query2_erroneous = """SELECT TOP 3000
WHERE parallax < 1
source_id, ra, dec, pmra, pmdec, parallax
FROM gaiadr2.gaia_source
"""

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Yes

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

The open issue was to changed wrond query by the correct one

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

query2_erroneous ="""SELECT 
TOP 3000
WHERE parallax < 1
source_id, ref_epoch, ra, dec, parallax
FROM gaiadr2.gaia_source
"""  The top query is wrong and have been replaced by this: query2_erroneous = """SELECT 
TOP 3000
WHERE parallax < 1
source_id, ra, dec, pmra, pmdec, parallax
FROM gaiadr2.gaia_source
"""
@ShebMichel ShebMichel requested a review from abostroem June 11, 2025 01:43
@ShebMichel ShebMichel added the status:in progress Contributor working on issue label Jun 11, 2025
Copy link

github-actions bot commented Jun 11, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/astronomy-python/compare/md-outputs..md-outputs-PR-246

The following changes were observed in the rendered markdown documents:

 01-query.md | 4 ++--
 md5sum.txt  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-06-11 01:46:31 +0000

github-actions bot pushed a commit that referenced this pull request Jun 11, 2025
Copy link

@ndporter ndporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears this query is supposed to be an example of the wrong order so the WHERE shouldn't actually be moved to where it belongs. It's meant to demonstrate that if you do put WHERE before FROM it will break things.

However, it's still worth fixing and merging this PR to harmonize the list of variables so this query is identical to query2 except the single breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:in progress Contributor working on issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants