Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visualizations to better explain image blurring in episode 6 #292

Merged
merged 5 commits into from
Aug 16, 2023

Conversation

chbrandt
Copy link
Contributor

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Closes #221

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

Added figures and respective python code for visualizing the effects of image blurring from a different perspective, as the pixel intensities profile.

If any relevant discussions have taken place elsewhere, please provide links to these.

Issue #221 has all the

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

chbrandt and others added 3 commits August 11, 2023 15:16
@github-actions
Copy link

github-actions bot commented Aug 11, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-292

The following changes were observed in the rendered markdown documents:

 06-blurring.md                                | 144 +++++++++++++++++++++++++-
 fig/3D_petri_after_blurring.png (new)         | Bin 0 -> 112819 bytes
 fig/3D_petri_before_blurring.png (new)        | Bin 0 -> 110601 bytes
 fig/petri-blurred-intensities-plot.png (new)  | Bin 0 -> 25872 bytes
 fig/petri-dish.png (new)                      | Bin 0 -> 119846 bytes
 fig/petri-original-intensities-plot.png (new) | Bin 0 -> 27789 bytes
 fig/petri-selected-pixels-marker.png (new)    | Bin 0 -> 114952 bytes
 md5sum.txt                                    |   2 +-
 8 files changed, 144 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-08-15 14:38:54 +0000

Add links to 3D plots gist
@chbrandt chbrandt marked this pull request as ready for review August 11, 2023 14:23
@chbrandt chbrandt changed the title Add visualizations to better explaing image blurring in episode 6 Add visualizations to better explain image blurring in episode 6 Aug 11, 2023
Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, @chbrandt, thank you. Almost ready for merge as it is. I have made a few proofreading and stylistic guide edits, and requested one change (to use a different word than "directory").

episodes/06-blurring.md Outdated Show resolved Hide resolved
episodes/06-blurring.md Outdated Show resolved Hide resolved
episodes/06-blurring.md Outdated Show resolved Hide resolved
episodes/06-blurring.md Show resolved Hide resolved
episodes/06-blurring.md Outdated Show resolved Hide resolved
episodes/06-blurring.md Outdated Show resolved Hide resolved
episodes/06-blurring.md Outdated Show resolved Hide resolved
Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this excellent contribution, @chbrandt. I hope you'll consider making more again in future!

github-actions bot pushed a commit that referenced this pull request Aug 15, 2023
@tobyhodges tobyhodges merged commit 1a34167 into datacarpentry:main Aug 16, 2023
github-actions bot pushed a commit that referenced this pull request Aug 16, 2023
Auto-generated via {sandpaper}
Source  : 1a34167
Branch  : main
Author  : Toby Hodges <tbyhdgs@gmail.com>
Time    : 2023-08-16 10:12:36 +0000
Message : Merge pull request #292 from chbrandt/chbrandt-patch-1

Add visualizations to better explain image blurring in episode 6
github-actions bot pushed a commit that referenced this pull request Aug 16, 2023
Auto-generated via {sandpaper}
Source  : 68be0d4
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-16 10:14:13 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 1a34167
Branch  : main
Author  : Toby Hodges <tbyhdgs@gmail.com>
Time    : 2023-08-16 10:12:36 +0000
Message : Merge pull request #292 from chbrandt/chbrandt-patch-1

Add visualizations to better explain image blurring in episode 6
@chbrandt
Copy link
Contributor Author

@tobyhodges I actually want to participate in the material/content creation in the Carpentries.

@chbrandt chbrandt deleted the chbrandt-patch-1 branch August 16, 2023 15:00
@tobyhodges
Copy link
Member

This is great to hear, @chbrandt. You can find some general information at https://carpentries.org/involved-lessons/, but I am also happy to answer specific questions by email tbyhdgs at gmail dot com.

github-actions bot pushed a commit that referenced this pull request Aug 22, 2023
Auto-generated via {sandpaper}
Source  : 68be0d4
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-16 10:14:13 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 1a34167
Branch  : main
Author  : Toby Hodges <tbyhdgs@gmail.com>
Time    : 2023-08-16 10:12:36 +0000
Message : Merge pull request #292 from chbrandt/chbrandt-patch-1

Add visualizations to better explain image blurring in episode 6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gaussian Blur not shown to be effective against noise
2 participants