Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start to remove stringsAsFactors references #145

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

mikemahoney218
Copy link
Member

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
This PR addresses #119 (it does not close it)

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
This PR does two main things:

  1. Updates Episode 3 to remove references to stringsAsFactors, and to update examples and text to match modern R versions.
  2. Updates Episode 4 to remove stringsAsFactors = FALSE where it no longer changes how the code works.

I also removed two stringsAsFactors calls from renv/activate.R which shouldn't change execution at all.

I left in the stringsAsFactors = TRUE seen in Episode 4, though I'm not confident it does anything, as well as the discussion of factors at the end of episode 4. I think there's probably a larger discussion to be had about if that section is serving our needs with R 4.3+, but I want to check and see if factors are used later in this workshop before I propose cutting it out.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/r-intro-geospatial/compare/md-outputs..md-outputs-PR-145

The following changes were observed in the rendered markdown documents:

 03-data-structures-part1.md | 112 ++++++++++++++++++++++++++++++--------------
 04-data-structures-part2.md |   8 ++--
 md5sum.txt                  |   4 +-
 3 files changed, 83 insertions(+), 41 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-09-20 19:15:27 +0000

github-actions bot pushed a commit that referenced this pull request Sep 20, 2023
@likeajumprope
Copy link

This sounds plausible to me. If @albhasan agrees I think we could merge this.

Copy link

@likeajumprope likeajumprope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound plausible to me.

@mikemahoney218 mikemahoney218 merged commit c66ed32 into main Oct 10, 2023
3 checks passed
@mikemahoney218 mikemahoney218 deleted the mikemahoney218_119 branch October 10, 2023 01:23
github-actions bot pushed a commit that referenced this pull request Oct 10, 2023
Auto-generated via {sandpaper}
Source  : c66ed32
Branch  : main
Author  : Michael Mahoney <mike.mahoney.218@gmail.com>
Time    : 2023-10-10 01:23:36 +0000
Message : Merge pull request #145 from datacarpentry/mikemahoney218_119

Start to remove stringsAsFactors references
github-actions bot pushed a commit that referenced this pull request Oct 10, 2023
Auto-generated via {sandpaper}
Source  : 7448787
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-10-10 01:25:39 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : c66ed32
Branch  : main
Author  : Michael Mahoney <mike.mahoney.218@gmail.com>
Time    : 2023-10-10 01:23:36 +0000
Message : Merge pull request #145 from datacarpentry/mikemahoney218_119

Start to remove stringsAsFactors references
@albhasan
Copy link
Contributor

This sounds plausible to me. If @albhasan agrees I think we could merge this.

I agree!

github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
Auto-generated via {sandpaper}
Source  : 7448787
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-10-10 01:25:39 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : c66ed32
Branch  : main
Author  : Michael Mahoney <mike.mahoney.218@gmail.com>
Time    : 2023-10-10 01:23:36 +0000
Message : Merge pull request #145 from datacarpentry/mikemahoney218_119

Start to remove stringsAsFactors references
github-actions bot pushed a commit that referenced this pull request Oct 24, 2023
Auto-generated via {sandpaper}
Source  : 7448787
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-10-10 01:25:39 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : c66ed32
Branch  : main
Author  : Michael Mahoney <mike.mahoney.218@gmail.com>
Time    : 2023-10-10 01:23:36 +0000
Message : Merge pull request #145 from datacarpentry/mikemahoney218_119

Start to remove stringsAsFactors references
github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
Auto-generated via {sandpaper}
Source  : 7448787
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-10-10 01:25:39 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : c66ed32
Branch  : main
Author  : Michael Mahoney <mike.mahoney.218@gmail.com>
Time    : 2023-10-10 01:23:36 +0000
Message : Merge pull request #145 from datacarpentry/mikemahoney218_119

Start to remove stringsAsFactors references
@albhasan albhasan mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants