Update 05-data-subsetting.Rmd #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L348 typo "drop = F0ALSE" Based on explanation on L315; the answer on the first part of Q1 Challenge 4 should be: It is trying to subset the first 20 columns in `gapminder`, but there are only 6 columns in `gapminder`. Hence, the code is invalid.
|
Thanks for this! Good catch on the typo. Although L315 is technically correct, I would personally advocate for always using comma notation for subsetting columns as I think it is much more clear and intuitive. My personal preference would be to change L315:L325 and keep the original text of the challenge 4 solution but I'm curious what other think. |
|
Good catch on typo. RE: Solution - would agree with @jsta here. If this is the route, lets create a separate issue for it and merge in the typo fix here? |
|
Moved typo fix to #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
L348 typo "drop = F0ALSE"
Based on explanation on L315; the answer on the first part of Q1 Challenge 4 should be:
It is trying to subset the first 20 columns in
gapminder, but there are only 6 columns ingapminder. Hence, the code is invalid.