Skip to content
This repository was archived by the owner on Oct 29, 2023. It is now read-only.

arm64 downloads #145

Closed
jpike88 opened this issue Jan 14, 2022 · 7 comments
Closed

arm64 downloads #145

jpike88 opened this issue Jan 14, 2022 · 7 comments
Assignees
@datacharmer
Labels
enhancement

Comments

@jpike88
Copy link

jpike88 commented Jan 14, 2022 •
edited
Loading

add some downloads for arm64, for M1 Macs. looks like just 8.0.27 but that's a good start
@jpike88
Copy link
Author

jpike88 commented Jan 14, 2022

makes sense to define a new OS: "DarwinARM64"

@datacharmer
Copy link
Owner

I have a couple of problems with this task at the moment:

  1. I don't own an M1 Mac. I can't just add the downloads for the new architecture, as it would require an update in the code, and I would also need to test the new downloads.
  2. Even if I find someone who would let me access an M1 remotely, I am unable to code now and I will be for several weeks, as an accident has deprived me of the use of my dominant hand.

That said, if someone would submit a pull request with the code changes and the downloads, I can have a look.

@jpike88
Copy link
Author

jpike88 commented Jan 15, 2022

No problem I could have a crack. Just a question regarding how you want to differentiate apple from intel chips in the list.json?

@datacharmer
Copy link
Owner

That depends on how an M1 defines itself. The operating system used in the tarball list must be detectable by the function CheckTarballOperatingSystem (in common/checks.go). As you can see from that function, figuring out the right type requires some experimentation. Probably it would be necessary replacing every occurrence of runtime.GOOS into a function that combines OS and architecture.

@jpike88
Copy link
Author

jpike88 commented Jan 15, 2022

that looks about right. I ran locally and got these values:

runtime.GOARCH => arm64
runtime.GOOS => darwin

datacharmer added a commit that referenced this issue Aug 15, 2022
@datacharmer
Add downloads for arm64 (Issue #145)
aa25fed
@datacharmer
Copy link
Owner

I have opened a new branch that should fix this issue. (https://github.com/datacharmer/dbdeployer/tree/arm-64-downloads)
It would be nice if someone with access to a arm64 architecture would compile this branch and test the downloads commands: get-by-version, add, add-remote, list, tree

@datacharmer datacharmer mentioned this issue Aug 15, 2022
Merged
datacharmer added a commit that referenced this issue Aug 27, 2022
@datacharmer
Add Arm64 downloads (#152)
eb48a4f 
* Add downloads for arm64 (Issue #145)
  To add arm64 downloads (for Macs M1 and M2) it was necessary to make adjustments to the current downloads.
  Until now, they were either MacOs or Linux. In order to preserve the current functionality without much change,  
  several downloads sub-commands have a new option --arch:
    * get-by-version
    * add (mandatory)
    * list
    * tree
* Fix remote_registry_test
* Update downloads version
* Update sanity_check.sh to skip beta versions
* Add capability for circular replication
* Add experimental .goreleaser config
* Improve test command run_sql_in_sandbox
   Add ability of doing comparisons other than "equals"
* Update docs
@datacharmer
Copy link
Owner

Release v1.69.0 resolves this issue

@datacharmer datacharmer self-assigned this Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@datacharmer datacharmer

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@datacharmer @jpike88