Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DFG-to-FOS mappings utility function #147

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Add DFG-to-FOS mappings utility function #147

merged 3 commits into from
Oct 14, 2022

Conversation

jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Oct 14, 2022 •
edited
Loading

Purpose

Convert between dfg subject vocabulary and Field of study vocabulary

closes: datacite/datacite#1586

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

digitaldogsbody
digitaldogsbody approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@digitaldogsbody digitaldogsbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

lib/bolognese/utils.rb Outdated Show resolved Hide resolved
digitaldogsbody
digitaldogsbody approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@digitaldogsbody digitaldogsbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor looks great!

@jrhoads jrhoads merged commit 38cff90 into master Oct 14, 2022
@jrhoads jrhoads deleted the oecd-crosswalk branch October 14, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitaldogsbody digitaldogsbody digitaldogsbody approved these changes

@richardhallett richardhallett Awaiting requested review from richardhallett

@bklaing2 bklaing2 Awaiting requested review from bklaing2

@kjgarza kjgarza Awaiting requested review from kjgarza

@svogt0511 svogt0511 Awaiting requested review from svogt0511

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DFG to FOS crosswalk utility function to Bolognese
2 participants
@jrhoads @digitaldogsbody