Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor alteration to test check. #834

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Minor alteration to test check. #834

merged 1 commit into from
Nov 3, 2023

Conversation

svogt0511
Copy link
Contributor

@svogt0511 svogt0511 commented Nov 3, 2023

Purpose

closes: #833

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@svogt0511 svogt0511 self-assigned this Nov 3, 2023
Copy link

cypress bot commented Nov 3, 2023

3 failed and 2 flaky tests on run #1016 ↗︎

3 84 7 0 Flakiness 2

Details:

Merge 1ecbf1c into f661f48...
Project: bracco Commit: 6f80b843b4 ℹ️
Status: Failed Duration: 06:28 💡
Started: Nov 3, 2023 1:36 AM Ended: Nov 3, 2023 1:42 AM
Failed  organization_admin/prefixes.test.ts • 1 failed test • Tests

View Output Video

Test Artifacts
ACCEPTANCE: ORGANIZATION_ADMIN | PREFIXES > can see prefixes when using capitalized identifier URL subdirectory Output Screenshots
Failed  client_admin/doi.test.ts • 1 failed test • Tests

View Output Video

Test Artifacts
ACCEPTANCE: CLIENT_ADMIN | DOIS > is creating a doi - FILE UPLOAD Output Screenshots
Failed  consortium_admin/contact.test.ts • 1 failed test • Tests

View Output Video

Test Artifacts
ACCEPTANCE: CONSORTIUM_ADMIN | CONTACTS > show repositories for consortium organization with missing contacts Output Screenshots
Flakiness  cypress/e2e/organization_admin/doi.test.ts • 2 flaky tests • Tests

View Output Video

Test Artifacts
ACCEPTANCE: ORGANIZATION_ADMIN | DOIS > is logged in to dois page Output Screenshots
ACCEPTANCE: ORGANIZATION_ADMIN | DOIS > can see dois when using capitalized identifier URL subdirectory Output Screenshots

Review all test suite changes for PR #834 ↗︎

@svogt0511 svogt0511 merged commit 46bc4b9 into main Nov 3, 2023
@svogt0511 svogt0511 deleted the 833-test branch November 3, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor alteration to test
2 participants