Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for rendering error with DOIs with null nameIdentifier #863

Merged
merged 1 commit into from
May 22, 2024

Conversation

codycooperross
Copy link
Contributor

@codycooperross codycooperross commented May 22, 2024

Purpose

Fix for rendering error with DOIs with null nameIdentifier.

closes: #862

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@codycooperross codycooperross requested a review from svogt0511 May 22, 2024 13:28
@codycooperross codycooperross merged commit 7ee1750 into main May 22, 2024
5 checks passed
@codycooperross codycooperross deleted the codycooperross/issue862 branch May 22, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOIs with null nameIdentifier may cause rendering error in Fabrica
2 participants