update NL goldens #4677
Merged
update NL goldens #4677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beets
approved these changes
Oct 18, 2024
|
also adding in webdriver/py test fixes because those are needed to pass all checks to merge this PR. additional updates made for the test fixes:
|
chejennifer
commented
Oct 18, 2024
| @@ -92,11 +92,6 @@ | |||
| "name": "China", | |||
| "place_type": "Country" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
this is from eurostat deprecation
chejennifer
commented
Oct 18, 2024
| @@ -86,23 +86,6 @@ | |||
| ], | |||
| "title": "Percentage That Sleeps Less Than 7 Hours Per Night in Counties of United States" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
there is another obesity vs sleep less than 7 hours chart on the page
chejennifer
commented
Oct 18, 2024
| @@ -180,62 +180,6 @@ | |||
| ], | |||
| "title": "Economic Activity: Nominal GDP (Nominal, Per Capita)" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
this is caused by deprecated data sets
chejennifer
commented
Oct 18, 2024
| @@ -4,6 +4,101 @@ | |||
| "categories": [ | |||
| { | |||
| "blocks": [ | |||
| { | |||
There was a problem hiding this comment.
this is because of refreshed data
chejennifer
commented
Oct 18, 2024
| @@ -387,13 +387,21 @@ | |||
| { | |||
| "tiles": [ | |||
| { | |||
| "barTileSpec": { | |||
There was a problem hiding this comment.
this is from updates to cdc500 dataset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating NL goldens after mixer push to staging