Use api key helper during app creation. #4969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
chejennifer
approved these changes
Feb 20, 2025
server/__init__.py
Outdated
| return '' | ||
|
|
||
| # If key is not found, return an empty string | ||
| logging.warning(f'No key found for project: {gcp_project}; path:{gcp_path}') |
There was a problem hiding this comment.
this is not necessarily true because this is also a case of the key not found in the environment
There was a problem hiding this comment.
Updated the log to include the environment variables that were also checked.
gmechali
approved these changes
Feb 20, 2025
|
|
||
| TODO: use this method everywhere else in this file | ||
| """ | ||
| """ |
There was a problem hiding this comment.
ultra nit: might be nice to take this helper method into a helper file, to keep this a bit emptier.
Obviously you're not introducing this so no pressure to make the change now :) but at least a TODO would be good!
There was a problem hiding this comment.
Chatted offline, will move to website/shared/lib/utils.py in follow up PR today!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate each instance of fetching api keys to use a single helper function.
Add a check to ensure that DC_API_KEY was provided as an environment variable when running in LITE mode.