Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move get_api_key helper to shared lib and refactor direct calls to secretmanager. #4972

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

clincoln8
Copy link
Contributor

  • Splits _get_api_key helper into get_gcp_secret and get_api_key. The latter first checks if api key is present as an environment variable and if not, then calls get_gcp_secret to fetch the key from GCP.

  • Migrates the two other secretmanager accesses in the website repo to use the get_gcp_secret helper in the shared lib utils.

@clincoln8 clincoln8 requested a review from gmechali February 21, 2025 23:42
Copy link
Contributor

@gmechali gmechali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I assume you did run local to confirm everything still works, but just calling it out in case :)

@clincoln8
Copy link
Contributor Author

LGTM - I assume you did run local to confirm everything still works, but just calling it out in case :)

The following commands for running locally worked:

./run_server.sh -e lite
./run_server.sh -e biomedical
./run_server.sh -m
./run_server.sh

Is there a way to test the change to runner.py and send_email.py?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants