391 csv import #392
Open
391 csv import #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonharrer pandas+clevercsv as new dependencies. Should we introduce a new "csv" extra? |
|
Yes, we should add an extra for that. |
jochenchrist
requested changes
Aug 29, 2024
| @@ -36,7 +36,9 @@ dependencies = [ | |||
| "opentelemetry-exporter-otlp-proto-http~=1.16", # move to extra? | |||
| "boto3>=1.34.41,<1.34.137", | |||
| # "botocore>=1.34.41,<1.34.137", | |||
| "jinja_partials >= 0.2.1" | |||
| "jinja_partials >= 0.2.1", | |||
| "clevercsv >= 0.8.2", | |||
There was a problem hiding this comment.
Please create an extra csv for these dependencies.
|
@jverhoeks Can I support you with this? |
|
I think this feature is a great addition to the CLI tool. How can we get this finished? @jverhoeks still in for it? |
|
i missed your comment, i'll rebase the code and add the dependencies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding CSV import with auto detection of the csv dialect (seperator,quote) and encoding.