Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving around library code into ingress/analysis/visualizetion submodules #540

Merged
merged 2 commits into from
Jan 3, 2022

Conversation

sbenthall
Copy link
Collaborator

Except where covered by other PRs. Fixes #537

@codecov-commenter
Copy link

Codecov Report

Merging #540 (4c4b6ba) into main (035bc60) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   74.83%   74.74%   -0.10%     
==========================================
  Files          22       22              
  Lines        3052     3041      -11     
==========================================
- Hits         2284     2273      -11     
  Misses        768      768              
Flag Coverage Δ
unittests 74.74% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bigbang/analysis/entity_resolution.py 83.05% <ø> (ø)
bigbang/analysis/process.py 44.69% <ø> (ø)
bigbang/analysis/thread.py 68.67% <ø> (ø)
tests/unit/test_archive.py 95.12% <ø> (-0.63%) ⬇️
bigbang/analysis/repo_loader.py 47.43% <100.00%> (ø)
bigbang/archive.py 71.01% <100.00%> (ø)
bigbang/ingress/git_repo.py 69.36% <100.00%> (ø)
bigbang/ingress/mailman.py 61.42% <100.00%> (ø)
bigbang/w3crawl.py 91.20% <100.00%> (ø)
tests/unit/test_bigbang.py 97.88% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035bc60...4c4b6ba. Read the comment docs.

@sbenthall
Copy link
Collaborator Author

Tests are passing and there's no pushback so I'll merge by the end of the day.

@sbenthall sbenthall merged commit 2c41b5c into datactive:main Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor old bigbang code into ingress/analysis/visualization
2 participants