Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the MaxConsumeCount param configurable #4

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

kedlas
Copy link
Contributor

@kedlas kedlas commented Oct 19, 2023

No description provided.

@prochac
Copy link
Contributor

prochac commented Oct 19, 2023

Let's use uint, negative values are useless here.
Also the merge should be synchronised with our update, as we rely on the former default value.

@kedlas
Copy link
Contributor Author

kedlas commented Oct 19, 2023

The merge sync is the reason why the default value is 3. I would prefer to have the default value 0 (disabled), but for that we must have all ourt consymers ready in advance. This change proposed does not change any configuration which we currently use.

@kedlas kedlas added the enhancement New feature or request label Oct 19, 2023
consumer.go Show resolved Hide resolved
@prochac
Copy link
Contributor

prochac commented Oct 20, 2023

The merge sync is the reason why the default value is 3. I would prefer to have the default value 0 (disabled), but for that we must have all ourt consymers ready in advance. This change proposed does not change any configuration which we currently use.

OK, let's migrate our code to explicitly use 3, or better, make it configurable by env, and later we can make the breaking change, as it's only us using this module so far :D

consumer.go Outdated Show resolved Hide resolved
consumer.go Outdated Show resolved Hide resolved
@kedlas kedlas merged commit 447b6ae into main Oct 23, 2023
6 checks passed
@prochac prochac deleted the consumed_count_disabled_by_default branch August 15, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants