Get attempt for consumed msg #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petans24
force-pushed
the
issue-5-get-attempt
branch
5 times, most recently
from
597247a
to
6de911c
Compare
petans24
force-pushed
the
issue-5-get-attempt
branch
3 times, most recently
from
00be0e9
to
48ed134
Compare
|
LGTM, the Message interface was a relict of the past. |
prochac
approved these changes
Nov 30, 2023
petans24
force-pushed
the
issue-5-get-attempt
branch
2 times, most recently
from
f7750fc
to
7c1b7de
Compare
petans24
force-pushed
the
issue-5-get-attempt
branch
from
7c1b7de
to
06664d2
Compare
|
We were testing it in our environment for some time. IMO ready to land the public :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding attempt field to Message struct make sense to split Message to MessageIncoming which keeps mechanisms how to handle msg and MessageOutgoing which works as payload definition.