fix(openalex): Update checkbox handling for affiliations selection

dataesr · Nov 26, 2024 · e7ae702 · e7ae702
1 parent d68c73e
commit e7ae702
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/client/src/pages/openalex-ror/results/list-view.jsx b/client/src/pages/openalex-ror/results/list-view.jsx
@@ -36,7 +36,7 @@ export default function ListView({
                 <div style={{ display: 'inline-flex' }}>
                   <div style={{ display: 'inline-block', width: '20px' }}>
                     <Checkbox
-                      checked={selectedOpenAlex.includes(affiliation)}
+                      checked={selectedOpenAlex.some((a) => a.key === affiliation.key)}
                       name="affiliations"
                       onChange={(e) => {
                         if (e.target.checked) {

diff --git a/client/src/pages/openalex-ror/results/views-selector.jsx b/client/src/pages/openalex-ror/results/views-selector.jsx
@@ -1,6 +1,7 @@
 import {
   Badge,
   Button,
+  Checkbox,
   Col,
   Modal, ModalContent, ModalFooter, ModalTitle,
   Row,
@@ -123,7 +124,7 @@ export default function ViewsSelector({
       >
         <Row>
           <Col xs="3">
-            <input
+            <Checkbox
               checked={(selectedOpenAlex.length === filteredAffiliations.length) && (selectedOpenAlex.length > 0)}
               className="fr-ml-2w"
               onChange={() => {
@@ -133,9 +134,8 @@ export default function ViewsSelector({
                   setSelectedOpenAlex([]);
                 }
               }}
-              type="checkbox"
             />
-            <span className="wm-text fr-mb-3w fr-ml-1w">
+            <span className="wm-text fr-mb-3w fr-ml-6w">
               <Badge color="brown-opera">
                 {selectedOpenAlex.length}
               </Badge>