-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1386 fix nextInt and nextLong with extreme boundaries #1388
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1388 +/- ##
============================================
- Coverage 92.32% 92.26% -0.06%
- Complexity 3152 3154 +2
============================================
Files 319 319
Lines 6146 6152 +6
Branches 592 593 +1
============================================
+ Hits 5674 5676 +2
- Misses 331 335 +4
Partials 141 141 ☔ View full report in Codecov by Sentry. |
Drop the unrelated workflow change? |
e.g. * `randomService.nextInt(Integer.MIN_VALUE, Integer.MAX_VALUE)` * `randomService.nextLong(Long.MIN_VALUE, Long.MAX_VALUE)` P.S. document the legacy behaviour of `nextLong` method (when min == max)
efd133a
to
b60ed48
Compare
To be clear I do think that's probably a handy change if you want to submit it separately. (I'll leave that approval/merge up to bodiam but for my two cents it's good) |
* @param min the maximum value | ||
* @param max the minimal value | ||
* @param min the minimum value | ||
* @param max the maximum value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha good catch, one of obviously didn't notice the mismatch.
I am not sure if it's useful. I wanted looked for a github action that would generate a readable test report. |
e.g.
randomService.nextInt(Integer.MIN_VALUE, Integer.MAX_VALUE)
randomService.nextLong(Long.MIN_VALUE, Long.MAX_VALUE)