Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

University name extension with places + testNoDuplications improvement #1394

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

badoken
Copy link
Contributor

@badoken badoken commented Oct 19, 2024

  • University.place is provided with common university locations in names
  • University.name is extended to provide realistic names like:
    • The Bahringer University of California
    • West Homenick Institute of Mumbai
    • Eastern Buckridge University of Grenoble

Source of names


  • Also testNoDuplications is updated to display the duplicates if found any

Copy link

what-the-diff bot commented Oct 19, 2024

PR Summary

  • Added New Method to Enhance University Location Specification
    A new function named 'place()' was added to the University.java. This function allows for the resolution of the term "university.place", helping to specify the location of a university more explicitly.

  • Extended University Location Entries
    The university.yml file has been extended by a new section named "place". It carries various location entries expanding the range of university places we can generate.

  • Updated Name Generation Format
    The format for generating names in the university.yml file has been updated. It now includes the newly added "place" field as a part of generated names. This allows the capability to create names that follow structures like "University Prefix, Last Name, University Suffix, University Place".

  • Improved Duplication Check Logic
    The logic involved in checking for duplicate terms in BaseFakerTest.java has been updated. This improved logic now captures and asserts duplicate terms more clearly, making foreseeing redundancy in terms quite easy.

  • Added Test Case for New Method
    A new test case has been added for the place method in the UniversityTest.java file. This ensures the validity of the new function and that it successfully integrates with the existing codebase.

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.22%. Comparing base (12bdd2a) to head (9fab970).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1394      +/-   ##
============================================
- Coverage     92.28%   92.22%   -0.07%     
  Complexity     3149     3149              
============================================
  Files           319      319              
  Lines          6145     6146       +1     
  Branches        592      592              
============================================
- Hits           5671     5668       -3     
- Misses          331      335       +4     
  Partials        143      143              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kingthorin kingthorin merged commit b931c81 into datafaker-net:main Oct 20, 2024
11 of 12 checks passed
asolntsev added a commit that referenced this pull request Oct 21, 2024
asolntsev added a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants